Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth labels #246

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Smooth labels #246

merged 6 commits into from
Feb 28, 2024

Conversation

haesleinhuepf
Copy link
Member

Hi @StRigaud ,

this adds smooth_labels() and fixes a bug in opening_labels.

closes #245
closes clEsperanto/pyclesperanto#144

Let me know what you think!

Cheers,
Robert

haesleinhuepf and others added 3 commits February 26, 2024 16:40
Co-Authored-By: Stephane Rigaud <811146+StRigaud@users.noreply.github.com>
Co-Authored-By: Stephane Rigaud <811146+StRigaud@users.noreply.github.com>
Co-Authored-By: Stephane Rigaud <811146+StRigaud@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 49.95%. Comparing base (efcd8fa) to head (f8a432b).

Files Patch % Lines
clic/src/tier8.cpp 40.00% 1 Missing and 5 partials ⚠️
clic/src/tier7.cpp 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   49.59%   49.95%   +0.36%     
==========================================
  Files          14       15       +1     
  Lines        3176     3187      +11     
  Branches     1341     1347       +6     
==========================================
+ Hits         1575     1592      +17     
+ Misses        547      533      -14     
- Partials     1054     1062       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud
Copy link
Member

But of course, It is amazing @haesleinhuepf !

Signed-off-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
@StRigaud
Copy link
Member

it should be good now :)

@kevinyamauchi
Copy link

This would be super useful for me! Thanks @haesleinhuepf and @StRigaud !

@StRigaud
Copy link
Member

This would be super useful for me! Thanks @haesleinhuepf and @StRigaud !

@kevinyamauchi, don't hesitate to make some feature or filter request 😉

@kevinyamauchi
Copy link

@kevinyamauchi, don't hesitate to make some feature or filter request 😉

@StRigaud , be careful what you wish for 😉

@haesleinhuepf haesleinhuepf merged commit e21651d into master Feb 28, 2024
5 checks passed
@haesleinhuepf haesleinhuepf deleted the smooth_labels branch February 28, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] relabel set to true in opening_labels while it should be false smooth_labels is missing in API
4 participants