Kernel of Laplace Box #157
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 77.34% 77.40% +0.06%
==========================================
Files 179 182 +3
Lines 8544 8623 +79
==========================================
+ Hits 6608 6675 +67
- Misses 1936 1948 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Isn't the norm calculated in line 18 of the laplace_box kernel supposed to be (r.z + r.y + r.x) * 2 instead of (r.z + r.y + r.z) * 2 ? |
|
Laplace norm should be fixed now, see: Tests shouldn't pass! Please, fix the tests so that it actually tests the laplace formula |
|
I have corrected the tests so that they can test the Laplace formula (they obviously still don't pass). |
| std::string cl_header = { | ||
| #include "cle_laplace_box.h" | ||
| }; | ||
| this->SetSource("laplace_box", cl_header); | ||
| } |
There was a problem hiding this comment.
Library was updated, this need to be changed as followed:
- move the include outside the function, at the top of the file
- replace
cl_headerbyoclKernel::laplace_box
see: absolute kernel for example
thirdparty/CMakeLists.txt
Outdated
| GIT_REPOSITORY https://github.com/CherifMZ/clij-opencl-kernels.git | ||
| GIT_TAG fix_laplace_box |
There was a problem hiding this comment.
Kernel is pushed to the clesperanto_kernel branch, you can update back the repository link and tag before final merge
No description provided.