-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel crop #145
Kernel crop #145
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 77.47% 77.51% +0.03%
==========================================
Files 176 179 +3
Lines 8428 8534 +106
==========================================
+ Hits 6530 6615 +85
- Misses 1898 1919 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@CherifMZ You will need to fix the formatting so that all tests pass |
tests/crop_test.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test should cover a bit more dimensions (1d,2d,3d) and data types (int, char, etc.).
As well as fit a bit more the API for using this kernel operation, see here
No description provided.