Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel crop #145

Merged
merged 12 commits into from
Mar 21, 2023
Merged

Kernel crop #145

merged 12 commits into from
Mar 21, 2023

Conversation

CherifMZ
Copy link
Contributor

No description provided.

@CherifMZ CherifMZ closed this Mar 15, 2023
@CherifMZ CherifMZ reopened this Mar 15, 2023
@StRigaud StRigaud self-requested a review March 15, 2023 09:43
@StRigaud StRigaud added request New feature or request kernel labels Mar 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Patch coverage: 78.12% and project coverage change: +0.03 🎉

Comparison is base (2908bd2) 77.47% compared to head (b7bf5f7) 77.51%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   77.47%   77.51%   +0.03%     
==========================================
  Files         176      179       +3     
  Lines        8428     8534     +106     
==========================================
+ Hits         6530     6615      +85     
- Misses       1898     1919      +21     
Impacted Files Coverage Δ
clic/include/core/clesperanto.hpp 93.33% <ø> (ø)
tests/crop_test.cpp 71.62% <69.56%> (ø)
clic/include/tier1/cleCropKernel.hpp 100.00% <100.00%> (ø)
clic/src/core/clesperanto.cpp 89.62% <100.00%> (+0.06%) ⬆️
clic/src/tier1/cleCropKernel.cpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@StRigaud
Copy link
Member

@CherifMZ You will need to fix the formatting so that all tests pass

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test should cover a bit more dimensions (1d,2d,3d) and data types (int, char, etc.).
As well as fit a bit more the API for using this kernel operation, see here

@StRigaud StRigaud marked this pull request as draft March 15, 2023 11:04
@StRigaud StRigaud marked this pull request as ready for review March 20, 2023 16:24
@StRigaud StRigaud merged commit 805e17d into clEsperanto:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants