-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend documentation: add_new_kernel #125
Conversation
Thanks for the help! Thinking about splitting the markdown file into smaller ones, as follow:
Large and long text file make people don't want to read. |
@StRigaud that sounds like an excellent idea. How about adding "How to contribute" as a new section to the guidelines document? It seems to fit well there (and that document is not very long yet). |
@StRigaud How about splitting the document into two like I just committed? (assuming we add a new how to contribute section to the guidelines) |
Codecov ReportBase: 77.88% // Head: 78.01% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 77.88% 78.01% +0.13%
==========================================
Files 164 167 +3
Lines 8043 8097 +54
==========================================
+ Hits 6264 6317 +53
- Misses 1779 1780 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Yes this is good. No need to over-split neither 😉
Yes! the guideline a here as a summary top file from which we can link to sub-documentation. |
Since when writing doc increase coverage? |
I was also surprised by this. I guess, writing documentation decreases the percentage of code - hence the test coverage of the entire project (code + documentation) is increased - still funny though ;-) |
a vicious incentive for pushing dev into writing documentation ;) |
Rearrange of the doc, plus added a few more on coding guideline and clang-format. Don't know if we need more for now. |
I just read your changes - looks great to me! |
This is a first draft extending the documentation for adding a new kernel. I added the sections
Add a new method to the Clesperanto class gateway
andAdd a valid test case
.