Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landuse fixes history interface deconflict with the latest tag #26

Merged
merged 159 commits into from
Jan 13, 2025

Conversation

glemieux
Copy link
Collaborator

@glemieux glemieux commented Jan 4, 2025

This brings landuse_fixes branch up to date with the latest tag, sci.1.80.6_api.37.0.0, and deconflicts the history interface mod. The main history conflicts appear to be due to changes that came in with NGEET#1197. Normally I would just push the deconflict directly, but I wanted to give you the option to bring it in just in case you were still doing any work/updates/science on this branch. If not feel free to just merge it.

@glemieux glemieux mentioned this pull request Jan 6, 2025
4 tasks
This is clean up from the deconflict merge
This cleans up a bad deconflict merge
@glemieux
Copy link
Collaborator Author

glemieux commented Jan 7, 2025

@ckoven I made two commits to address the npp questions that I had this morning, 69e7433 and e4a163d. Would you review them when you get a chance?

Copy link
Owner

@ckoven ckoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see one issue here I think?

main/FatesHistoryInterfaceMod.F90 Outdated Show resolved Hide resolved
@ckoven ckoven merged commit 22f7249 into ckoven:landuse_fixes Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants