Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BLOBHASH and BLOBBASEFEE #9

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Rjected
Copy link
Contributor

@Rjected Rjected commented Sep 27, 2023

Was trying to disassemble some cancun contracts with cast disassemble and noticed these needed to be added

@ckoopmann ckoopmann self-requested a review October 24, 2023 03:27
Copy link
Owner

@ckoopmann ckoopmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Changes look good to me.
One question:
What is the authoritative source on the new opcodes to be introduced in Cancun ?
For example it seems that there might also be a "BEACON_ROOT" opcode to be introduced but I couldn't find any info on wether this EIP will actually be part of cancun.

@Rjected
Copy link
Contributor Author

Rjected commented Oct 24, 2023

The best way to track which EIPs will be in cancun is to check the devnet spec:
https://notes.ethereum.org/@ethpandaops/dencun-devnet-10

We are also implementing as many as possible in revm:
https://github.com/bluealloy/revm/blob/47b38af503ee9506b48b2cda8e8f06abf6093e14/crates/interpreter/src/instructions/opcode.rs

Also see the new point evaluation precompile in revm:
https://github.com/bluealloy/revm/blob/47b38af503ee9506b48b2cda8e8f06abf6093e14/crates/precompile/src/lib.rs#L204-L227

EIP-4788 is included in cancun, but instead of being a stateful precompile it is now a regular contract.

@ckoopmann
Copy link
Owner

The best way to track which EIPs will be in cancun is to check the devnet spec: https://notes.ethereum.org/@ethpandaops/dencun-devnet-10

We are also implementing as many as possible in revm: https://github.com/bluealloy/revm/blob/47b38af503ee9506b48b2cda8e8f06abf6093e14/crates/interpreter/src/instructions/opcode.rs

Also see the new point evaluation precompile in revm: https://github.com/bluealloy/revm/blob/47b38af503ee9506b48b2cda8e8f06abf6093e14/crates/precompile/src/lib.rs#L204-L227

EIP-4788 is included in cancun, but instead of being a stateful precompile it is now a regular contract.

Thanks, that helps a lot 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants