Introducing DataProcessor#registerRawContentElementMatcher() #8529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g of whitespaces after inline raw content element. Added test.
jodator
suggested changes
Nov 26, 2020
There was a problem hiding this comment.
I would add more tests for the new method. We should add more test cases to define what happens in a scenario, where two or more features registers raw content.
The method name is a bit long, so I've proposed a shorter one as I think that Element part is redundant. But that's up to you to decide whether you think that's a valid comment.
| @@ -158,6 +158,42 @@ describe( 'DomConverter', () => { | |||
| expect( viewFragment2 ).to.equal( viewFragment ); | |||
| } ); | |||
|
|
|||
| it( 'should assign $rawContent custom property for view elements registered as raw content elements', () => { | |||
There was a problem hiding this comment.
Too few tests IMO. Right now it tests only one pattern. I think that we could check a bit more:
- multiple patterns registered
- what if
div.raw-content-containerhas other attributes, classed or styles, iediv[ data-foo="bar"].raw-content-container
Co-authored-by: Maciej <jodator@jodator.net>
Reinmar
reviewed
Nov 26, 2020
Co-authored-by: Piotrek Koszuliński <pkoszulinski@gmail.com>
…RawContentMatcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (engine): Introducing
DataProcessor#registerRawContentMatcher().Fix (html-embed): Editor should not crash after inserting a broken HTML. Closes #8323.
Fix (engine):
DomConvertershould not trim whitespaces in nodes that are siblings to inline raw content elements (e.g. MathML). Closes #5870.Additional information