-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocumentSelection#markers collection should be updated only for observed markers groups #8484
Conversation
… markers change only changed markers are checked for DocumentSelection#markers collection.
I left some review comments, minor stuff. I have one doubt, though. This is connected with the fact that we never forced any structure for markers and something like "marker group" was not really specified (outside of API docs). It just appeared that in 99% of cases there are multiple markers of the same type and it makes sense to handle all of them in the same way. Hence, we have The problem is that it is still possible to create a marker with a name that does not have |
…sibility to observe individual markers.
Suggested merge commit message (convention)
Other (engine): The
DocumentSelection#markers
collection is updated only for observed markers groups.BREAKING CHANGE (engine): The
DocumentSelection#markers
collection is no longer enabled by default.DocumentSelection#observeMarkersGroup()
must be used to register markers group to be observed.Additional information
This is performance optimization.