Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6749: Updated table mocking tools to preserve cells' content. #6750

Merged
merged 2 commits into from
May 7, 2020

Conversation

niegowski
Copy link
Contributor

Suggested merge commit message (convention)

Internal: Updated table mocking tools to preserve cells' content. Closes #6749.


Additional information

@niegowski niegowski changed the title Updated table mocking tools to preserve cells' content. #6749: Updated table mocking tools to preserve cells' content. May 6, 2020
@niegowski niegowski requested a review from jodator May 6, 2020 16:52
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave the previous simple table. Anything complex looks like single case scenario.

[ '20', '21', '22', '23', '24' ],
[ '30', '31', '32', '33', '34' ],
[ '40', '41', '42', '43', '44' ]
[ '00', { contents: '01', colspan: 2, rowspan: 2 }, { contents: '03', rowspan: 2 }, '04', '05' ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave simple table as a base here. A simple table is better to start changing its structure. Providing complex table looks like one-case scenario only.

Co-authored-by: Maciej <jodator@jodator.net>
@niegowski niegowski requested a review from jodator May 7, 2020 08:04
@jodator jodator merged commit e87a95b into master May 7, 2020
@jodator jodator deleted the i/6749 branch May 7, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table mocking tools should not automatically generate cells' contents
2 participants