Do not attach refresh token interval if initialization of token failed in init() method of CloudServices plugin.
#17686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (cloud-services): No longer keep refreshing token if
tokenUrlmethod failed in the initialization of the plugin. Closes #17531Additional information
Related to #17462.
The
initmethod of theTokentries to initialize the token, but if the first initialization fails (that one ininitofcloud-services) it keeps the refresh interval running after destroying of the editor. The editor was destroyed becauseToken.initthrows exception directly incloud-servicesinit method (which leads to editor crash).