Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for latin-alpha / upper-alpha list type highlighting in list style properties buttons. #17627

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Dec 11, 2024

Suggested merge commit message (convention)

Feature (list): Add support for lower-alpha / upper-alpha list type highlighting in list style properties buttons. Closes #17424
Fix (list): The list style buttons should show proper list type after clicking list for the first time.

MINOR BREAKING CHANGE (list): lower-alpha and upper-alpha list styles are now upcasted to lower-latin and upper-latin styles.


Additional information

Aliasing

According to https://www.w3.org/TR/1998/PR-CSS2-19980324/lists.html#list-props:

lower-latin or lower-alpha
    Lower case ascii letters (a, b, c, ... z). 
upper-latin or upper-alpha
    Upper case ascii letters (A, B, C, ... Z). 

So it's valid to highlight the same list style property button.

Focus tracking

Before
before-list-focus-fix-2024-12-11_20.16.42.mp4
After
after-list-focus-fix-2024-12-11_20.15.24.mp4

@Mati365 Mati365 force-pushed the ck/17424 branch 3 times, most recently from ce8915f to 4a60a92 Compare December 11, 2024 19:10
@Mati365 Mati365 requested review from arkflpc, oleq, niegowski and pszczesniak and removed request for oleq December 11, 2024 19:18
pszczesniak
pszczesniak previously approved these changes Dec 12, 2024
Copy link
Contributor

@pszczesniak pszczesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Witoso
Copy link
Member

Witoso commented Dec 12, 2024

Shouldn't it be marked as Minor BC, as it introduces a potential content change for integrators?

@Mati365
Copy link
Member Author

Mati365 commented Dec 12, 2024

@Witoso It modifies only the state of UI button and focus of opened toolbar balloon. I'm not sure if it's needed.

@Mati365 Mati365 marked this pull request as draft December 12, 2024 09:31
…t. Improve focus management in list style balloon.
Copy link
Contributor

@pszczesniak pszczesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Nitpick: to consider - renaming normalizeListStyle to getNormalizedListStyle.

@Mati365
Copy link
Member Author

Mati365 commented Dec 13, 2024

I'm squashing and merging, any further issues will be fixed in later PRs.

@Mati365 Mati365 merged commit 2b2923a into master Dec 13, 2024
9 checks passed
@Mati365 Mati365 deleted the ck/17424 branch December 13, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recognize {lower,upper}-alpha list style types as aliases for {lower,upper}-latin in UI
3 participants