Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose API methods for providing custom links providers. #17593

Merged

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Dec 4, 2024

Suggested merge commit message (convention)

Internal (links): Expose API methods for providing custom links providers.


Additional information

Part of #17230
Manual demo added http://localhost:8125/ckeditor5-link/tests/manual/linkproviders.html

After

links-api-2024-12-06_14.02.35.mp4

@Mati365 Mati365 marked this pull request as draft December 4, 2024 15:00
@Mati365 Mati365 force-pushed the ck/epic/17230-abstract-link-preview branch from dba6882 to 36c9011 Compare December 5, 2024 09:18
Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial partial review.

packages/ckeditor5-bookmark/src/bookmarkui.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/linkediting.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/linkui.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/linkui.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/linkui.ts Outdated Show resolved Hide resolved
packages/ckeditor5-bookmark/src/bookmarkui.ts Outdated Show resolved Hide resolved
packages/ckeditor5-bookmark/src/bookmarkui.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/ui/linkprovideritemsview.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/ui/linkprovideritemsview.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/ui/linkprovideritemsview.ts Outdated Show resolved Hide resolved
@Mati365 Mati365 marked this pull request as ready for review December 6, 2024 13:03
Copy link
Contributor

@pszczesniak pszczesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

To be remembered: CSS must be updated when unifying forms will be done.

@Mati365 Mati365 merged commit b6f332e into ck/epic/17230-linking-experience Dec 10, 2024
7 checks passed
@Mati365 Mati365 deleted the ck/epic/17230-abstract-link-preview branch December 10, 2024 13:14
@Mati365
Copy link
Member Author

Mati365 commented Dec 10, 2024

Squashed & merged, I'll fix later issues in followups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants