-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose API methods for providing custom links providers. #17593
Merged
Mati365
merged 35 commits into
ck/epic/17230-linking-experience
from
ck/epic/17230-abstract-link-preview
Dec 10, 2024
Merged
Expose API methods for providing custom links providers. #17593
Mati365
merged 35 commits into
ck/epic/17230-linking-experience
from
ck/epic/17230-abstract-link-preview
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mati365
force-pushed
the
ck/epic/17230-abstract-link-preview
branch
from
December 5, 2024 09:18
dba6882
to
36c9011
Compare
niegowski
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial partial review.
arkflpc
reviewed
Dec 9, 2024
arkflpc
approved these changes
Dec 10, 2024
niegowski
reviewed
Dec 10, 2024
pszczesniak
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
To be remembered: CSS
must be updated when unifying forms will be done.
Squashed & merged, I'll fix later issues in followups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (links): Expose API methods for providing custom links providers.
Additional information
Part of #17230
Manual demo added http://localhost:8125/ckeditor5-link/tests/manual/linkproviders.html
After
links-api-2024-12-06_14.02.35.mp4