-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not show back button if balloon was not opened using another balloon. #17562
Do not show back button if balloon was not opened using another balloon. #17562
Conversation
f5ab382
to
0f4631d
Compare
This should be implemented for all balloons
as someone can add them to the main toolbar, not balloon. To test: behavior in the block toolbar / menu bar. (no back) |
Hm, I implemented that this way, but I thought that it's impossible to set custom size using menubar / or toolbar for such features. I'll check them, last time there were issues with them regarding the toolbar placement. |
72ad12f
to
ab85639
Compare
ab85639
to
fed492f
Compare
@Witoso I checked both places, and I was unable to open image resize / image text alternative widget balloons without having image selected. It's crucial because selection of image triggers showing the default widget toolbar, which is being hidden after stacking another balloon on top of it (and after pressing back in these stacked balloons, it's shown again). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a strange behavior when you put caret in a link (link toolbar appears) and you hit Cmd+K. There is no back button but it should be there.
Will check that. edit: 🤦 It looks like toolbar button intercepts CTRL+K so technically, it's opened via toolbar. |
@niegowski I simplified logic, it should work fine after modification. |
Suggested merge commit message (convention)
Internal (bookmark, link, image): Do not show back button if balloon was not opened using another balloon.
Fix (image): No longer crash editor when using image resize buttons in toolbar.
Additional information
Take a look at back button arrows.
Before
before-hide-arrows-2024-12-02_11.56.34.mp4
After
after-hide-arrows-2024-12-02_11.55.08.mp4