Encode the ampersand character when pasting link address #15231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
reviewed
Oct 24, 2023
| @@ -18,6 +18,8 @@ export default function plainTextToHtml( text: string ): string { | |||
| // Encode <>. | |||
| .replace( /</g, '<' ) | |||
| .replace( />/g, '>' ) | |||
| // Encode &. | |||
| .replace( /&/g, '&' ) | |||
There was a problem hiding this comment.
This is most probably to late, it would encode previously encoded < and >.
There was a problem hiding this comment.
Yes, I already pushed a commit with the proper order of encoding.
niegowski
reviewed
Oct 24, 2023
niegowski
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (clipboard): Pasting a link address should not convert its parts that look like HTML entities. Closes #15036.
Additional information
To reproduce the issue:
×,¶,"etc.) in its href, e.g. https://example.com?x=1"=2×tamp=tWithout this fix, the parts
"and×are replaced with corresponding characters.