Manual test with simple image #15222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize attributes and not rely on styles.
arkflpc
requested changes
Oct 26, 2023
| const imageUtils: ImageUtils = editor.plugins.get( 'ImageUtils' ); | ||
|
|
||
| // Waiting for any new images loaded, so we can set their natural width and height. | ||
| editor.editing.view.document.on( 'imageLoaded', ( evt, domEvent ) => { |
There was a problem hiding this comment.
You used event type in line 33. Why don't do that here.
| } | ||
|
|
||
| ClassicEditor | ||
| .create( document.getElementById( 'editor' ), { |
There was a problem hiding this comment.
It does not compile for me. getElementById can return null.
| continue; | ||
| } | ||
|
|
||
| const item = change.range.start.nodeAfter; |
There was a problem hiding this comment.
The lines below do not compile for me. nodeAfter can return null.
arkflpc
approved these changes
Oct 26, 2023
filipsobol
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (image): Added manual test with overridden image conversion to use only size attributes for images. Closes #15185.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.