Handling of dragging document list items. #15030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
reviewed
Sep 20, 2023
| // See https://github.com/ckeditor/ckeditor5/issues/11608, https://github.com/ckeditor/ckeditor5/issues/14969 | ||
| this.listenTo<ViewDocumentClipboardOutputEvent>( viewDoc, 'clipboardOutput', ( evt, data ) => { | ||
| if ( data.method != 'dragstart' ) { | ||
| const selection = model.document.selection; |
There was a problem hiding this comment.
I'm not sure if this is safe, in the previous implementation the provided selection was used and it could be different than the current document selection. Maybe we could check the content instead?
niegowski
reviewed
Sep 20, 2023
| if ( isSingleListItemSelected ) { | ||
| model.change( writer => removeListAttributes( Array.from( evt.return!.getChildren() as any ), writer ) ); | ||
| if ( isSingleListItemSelected ) { | ||
| const content = this.editor.data.toModel( data.content ); |
There was a problem hiding this comment.
This does not alter the clipboard content. As talked f2f let's introduce the outputTransformation event.
…d-dropping-document-lists
…d-dropping-document-lists # Conflicts: # packages/ckeditor5-clipboard/src/dragdropexperimental.ts
arkflpc
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (list): Dragged selected whole list item should be still a list item after drop. Closes #14969 .
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.