Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: updating demos CSS. #14998

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Docs: updating demos CSS. #14998

merged 3 commits into from
Sep 15, 2023

Conversation

godai78
Copy link
Contributor

@godai78 godai78 commented Sep 14, 2023

Suggested merge commit message (convention)

Docs: updating demos CSS. Closes #14995


Additional information

Merge together with https://github.com/cksource/ckeditor5-commercial/pull/5514

@Witoso
Copy link
Member

Witoso commented Sep 14, 2023

  • The inline editor example is still jumping, I think classes need to be added to all direct containers of the editor, e.g. header. Not sure, as maybe a different CSS styles it.
  • Classic behaves perfectly, full-featured is also a classic but the image jumps left to right (better than right now, anyway). My bad didn't have the commercial repo updated. Thanks @pszczesniak .

@godai78
Copy link
Contributor Author

godai78 commented Sep 15, 2023

This one is hard, adding the class to the very container holding the affected content made things even worse.

Adding a loader class (like we do in CF) to postpone display before loading did nothing at all.

I changed the image alignment to the left, so it jumps a little less, but I can come up with no handy solution for that.

We might consider putting it into a follow up, if we want global changes fast. We may also give up the image, but that's an unpreferred solution.

@Witoso
Copy link
Member

Witoso commented Sep 15, 2023

Good for me 👍

@godai78 godai78 merged commit be71de9 into stable Sep 15, 2023
@godai78 godai78 deleted the ck/14995 branch September 15, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants