Preview logic requires tweaking #14983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
requested changes
Sep 13, 2023
| } | ||
|
|
||
| const domEditablePaddingLeft = parseInt( computedStyle.paddingLeft.slice( 0, computedStyle.paddingLeft.length - 2 ) ); |
There was a problem hiding this comment.
Padding could be a non-integer. Also the parseInt() and parseFloat() functions parse the string until they encounter a non-numeric character so we do not need to trim the unit from the value.
Suggested change
| const domEditablePaddingLeft = parseInt( computedStyle.paddingLeft.slice( 0, computedStyle.paddingLeft.length - 2 ) ); | |
| const domEditablePaddingLeft = parseFloat( computedStyle.paddingLeft ); |
| } ); | ||
|
|
||
| expect( widgetToolbarRepository.isEnabled ).to.be.true; | ||
| } ); | ||
|
|
||
| it( 'should show preview with custom implementation', () => { |
There was a problem hiding this comment.
Those tests should not be inside the WidgetToolbarRepository#isEnabled group.
| const domEditable = editor.editing.view.domConverter.mapViewToDom( editable ); | ||
| const computedStyle = window.getComputedStyle( domEditable ); | ||
| const paddingLeftString = computedStyle.paddingLeft; | ||
| const paddingLeft = parseInt( paddingLeftString.slice( 0, paddingLeftString.length - 2 ) ); |
There was a problem hiding this comment.
Suggested change
| const paddingLeft = parseInt( paddingLeftString.slice( 0, paddingLeftString.length - 2 ) ); | |
| const paddingLeft = parseFloat( paddingLeftString ); |
filipsobol
reviewed
Sep 14, 2023
filipsobol
reviewed
Sep 14, 2023
filipsobol
reviewed
Sep 14, 2023
filipsobol
reviewed
Sep 14, 2023
filipsobol
reviewed
Sep 14, 2023
filipsobol
approved these changes
Sep 14, 2023
niegowski
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (clipboard): improve displaying preview in "drag and drop". Closes #14968.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.