enablePlaceholder() API should remain backward compatible for some time #14753
Conversation
| isDirectHost: false | ||
| } ); | ||
| viewRoot.placeholder = 'new placeholder'; | ||
|
|
||
| expect( viewRoot.getChild( 0 ).getAttribute( 'data-placeholder' ) ).to.equal( 'new placeholder' ); | ||
| } ); | ||
|
|
||
| it( 'should through warning once if "text" is used as argument', () => { |
There was a problem hiding this comment.
What did you mean by "should through warning once"?
There was a problem hiding this comment.
Warning should be through only once in dev console
|
And my assumption was correct, the test are failing on CI: https://app.travis-ci.com/github/ckeditor/ckeditor5/jobs/607359829 |
|
@mlewand There is one additional suggestion by @Dumluregn to perform displaying warning by
Is worth to mention when you open your dev console you will see only error name with link to the documentation.
What do you think? |
Yes, it makes sense @illia-stv! I missed that one. |
| ); | ||
| /** | ||
| * The "text" option in the {@link module:engine/view/placeholder~enablePlaceholder `enablePlaceholder()`} | ||
| * function is already deprecated and will be removed soon. Please update your code. |
There was a problem hiding this comment.
Oh, this new description is missing link to the migration guide that you provided below. That's very helpful so it needs to be here.
I'll add it as a part of R.
…I-should-remain-backward-compatible-for-some-time Fix (engine): Made the `enablePlaceholder()` API to remain backward compatible for the deprecation period. It will be removed in the future. Closes #14743.
Suggested merge commit message (convention)
Fix (engine): enablePlaceholder() API remain backward compatible for some time. Closes #14743.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.