Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide for changed placeholder API #14686

Merged

Conversation

illia-stv
Copy link
Contributor

Suggested merge commit message (convention)

Docs (updating): migration guide for changed placeholder API. Closes #14675.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@illia-stv illia-stv self-assigned this Jul 28, 2023
@illia-stv illia-stv changed the title Docs (updating): migration guide for changed placeholder API Migration guide for changed placeholder API Jul 28, 2023
@mlewand
Copy link
Contributor

mlewand commented Jul 31, 2023

The fix should go to a file related to that specific upgrade. In this case it's a file for v39.x release.


Docs (updating): migration guide for changed placeholder API. Closes #14675.

Our commit msg standard follows a "Type(package): msg" format. There's no package called updating.

@mlewand mlewand force-pushed the ck/14675-migration-guide-for-changed-placeholder-text-API branch from e55cb0d to ba58082 Compare July 31, 2023 13:26
@mlewand mlewand changed the base branch from master to release July 31, 2023 13:26
@mlewand
Copy link
Contributor

mlewand commented Jul 31, 2023

Changed the base branch to release this is what's used for the upcoming release after the code has been frozen.

mlewand added 2 commits July 31, 2023 15:37
… the upcoming version. Added links and some minor simplifications.
@mlewand mlewand self-requested a review July 31, 2023 13:53
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of adjustments - now it's ready to go.

Let's just wait for the CI to pass to merge it.

} );
```

Now if you need to update your placeholder you could just update `placeholder` property in your element.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll drop this part as this is not a part of breaking change (it wasn't possible before, so there's no need to explain it here).

@mlewand mlewand merged commit 08671b3 into release Aug 1, 2023
@mlewand mlewand deleted the ck/14675-migration-guide-for-changed-placeholder-text-API branch August 1, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration guide for changed placeholder text API
2 participants