-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration guide for changed placeholder API #14686
Migration guide for changed placeholder API #14686
Conversation
The fix should go to a file related to that specific upgrade. In this case it's a file for v39.x release.
Our commit msg standard follows a "Type(package): msg" format. There's no package called updating. |
e55cb0d
to
ba58082
Compare
Changed the base branch to |
… the upcoming version. Added links and some minor simplifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of adjustments - now it's ready to go.
Let's just wait for the CI to pass to merge it.
docs/updating/updating-ckeditor-5.md
Outdated
} ); | ||
``` | ||
|
||
Now if you need to update your placeholder you could just update `placeholder` property in your element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll drop this part as this is not a part of breaking change (it wasn't possible before, so there's no need to explain it here).
Suggested merge commit message (convention)
Docs (updating): migration guide for changed placeholder API. Closes #14675.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.