Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap replace all changes into one transaction. #14685

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Wrap replace all changes into one transaction. #14685

merged 3 commits into from
Jul 28, 2023

Conversation

pszczesniak
Copy link
Contributor

Suggested merge commit message (convention)

Fix (find-and-replace): Undo should restore every text occurrences replaced by replace all in the document at once..

Closes #13892.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@Dumluregn Dumluregn self-requested a review July 28, 2023 13:29
Dumluregn
Dumluregn approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@Dumluregn Dumluregn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, I made the multiroot test a bit clearer. Waiting for the CI.

@Dumluregn Dumluregn merged commit cfab99d into master Jul 28, 2023
@Dumluregn Dumluregn deleted the ck/13892-find-and-replace-replace-all-and-undo branch July 28, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dumluregn Dumluregn Dumluregn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find and replace replace all & undo
2 participants
@pszczesniak @Dumluregn