Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image resizedHeight model attribute (convert from style height) #14520

Merged
merged 43 commits into from
Jul 6, 2023
Merged

Add image resizedHeight model attribute (convert from style height) #14520

merged 43 commits into from
Jul 6, 2023

Conversation

mmotyczynska
Copy link
Contributor

Suggested merge commit message (convention)

Feature (image): Add image resizedHeight model attribute converted from image height style. Closes #14357.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

mmotyczynska added 30 commits June 7, 2023 14:11
@mmotyczynska
Add converter for image resizedHeight.
82975fe
@mmotyczynska
Remove resizedHeight on image resize.
65065ab
@mmotyczynska
Set inline aspect-ratio on image in editing downcast.
c80b762
@mmotyczynska
Update resizedHeight on image resize (when resize unit is px).
c2b8cff
@mmotyczynska
Add PFO to manual test with image size attributes.
8345334
@mmotyczynska
Add manual test for image size attributes with ghs.
d3a2752
@mmotyczynska
Revert "Update resizedHeight on image resize (when resize unit is px)."
226d1cd 
This reverts commit c2b8cff.
@mmotyczynska
Reverse changes in image.css.
6ba54a6
@mmotyczynska
Add height: auto for resized images (downcast).
603e961
@mmotyczynska
Change upcast and downcast of image attributes.
007ddec
@mmotyczynska
Set aspect-ratio for image view when resizing begins.
7d429e3
@mmotyczynska
Manual test with many image resize attributes test cases.
1f1be62
@mmotyczynska
Upcast height style to height attribute if no other styles/attributes…
fc13ab7 
… are provided.
@mmotyczynska
Convert resizedHeight to resizedWidth if there are attributes.
e29e786
@mmotyczynska
Correct manual test for image resize in px style only.
02578a8
@mmotyczynska
Upcast image aspect-ratio.
470be3f
@mmotyczynska
Revert "Upcast image aspect-ratio."
02b1fb0 
This reverts commit 470be3f.
@mmotyczynska
Revert "Convert resizedHeight to resizedWidth if there are attributes."
941e9d1 
This reverts commit e29e786.
@mmotyczynska
Revert "Upcast height style to height attribute if no other styles/at…
9ccaf9e 
…tributes are provided."

This reverts commit fc13ab7.
@mmotyczynska
Do not remove image_resized class when removing style height but styl…
bbb9f4a 
…e width is still set.
@mmotyczynska
Remove unused styles.
58ec57d
@mmotyczynska
For image inline in editing set height style on img instead of span.
aafb59e
@mmotyczynska
Remove style height from img after starting resizing.
e4faaa8
@mmotyczynska
Remove style height after starting resizing - fix for block images.
5a851e5
@mmotyczynska
Tests: image resize schema allowed attributes.
d8cea9a
@mmotyczynska
Refactor editing downcast for resizedHeight.
7b3e614
@mmotyczynska
Tests: image block resizedHeight downcast.
ecbd6e9
@mmotyczynska
Tests: image inline resizedHeight downcast.
4c71086
@mmotyczynska
Tests: image resizedWidth & resizedHeight upcast.
eb3bf54
@mmotyczynska
Tests: image upcast from styles to attributes.
93d0efe
@arkflpc arkflpc self-requested a review July 4, 2023 08:33
@arkflpc arkflpc marked this pull request as ready for review July 4, 2023 08:33
@mmotyczynska mmotyczynska requested a review from arkflpc July 5, 2023 11:52
@arkflpc arkflpc merged commit dfe8da2 into ck/epic/14146-support-image-height-attribute Jul 6, 2023
@arkflpc arkflpc deleted the ck/14357-add-image-resizedHeight-attribute-convert-from-style-height_poc branch July 6, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkflpc arkflpc arkflpc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmotyczynska @arkflpc