-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow and preserve image width and height #14233
Allow and preserve image width and height #14233
Conversation
…preserve-image-width-and-height
@ckeditor/qa-team , can you look at it? |
@arkflpc Sure, we will take a look at this 🕵️ |
The first change:
The second change:
Manual tests:
What to check:
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
…preserve-image-width-and-height
We have finished testing ✨ @charlttsie @dufipl thank you for the jolly cooperation 🍻 |
Suggested merge commit message (convention)
Feature (image): It should be possible to load and preserve image
width
andheight
attributes. Closes #14201.MAJOR BREAKING CHANGE (image): The name of the image resize
width
attribute has been changed toresizedWidth
. Thewidth
andheight
attributes are now used to preserve image width and height.MAJOR BREAKING CHANGE (image): The
srcset
attribute has been simplified. It is no longer an object{ data: "...", width: "..." }
, but a value previously stored in thedata
part.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.