-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declarative nested toolbars #12506
Declarative nested toolbars #12506
Conversation
@oleq regarding moving the icons, why Regarding the default icon, where do you see it kicking in? Would that it's added as an opt-out (so that integrator has to pass |
Because we're already collecting icons there. Alignment icons are there, object alignment icons too. And blockquote. All icons that could be (or already are) re-used by other features. I don't say this is the best place, though. Honestly I don't know why we have icons scattered across the project. They don't make sense without
The latter. But this is not critical I guess. There are warnings logged if you fail to provide either an icon or |
Co-authored-by: Arkadiusz Filipczak <ark.flp@gmail.com>
I made some changes, as we use "drop-down" (hyphenated) when it's an adjective, and here we mostly had nouns. |
…e to configure a drop-down without an icon and a visible text label.
Suggested merge commit message (convention)
Feature (ui): Allowed grouping toolbar items into drop-downs by using a declarative config. Closes #12490.
BREAKING CHANGE (basic-styles): The bold icon has been moved to the
ckeditor5-core
package.BREAKING CHANGE (paragraph): The paragraph icon has been moved to the
ckeditor5-core
package.Additional information
TODOs:
ckeditor5-core
package (e.g. while italic and heading1 didn't)?