Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in the console when using on JSFiddle #930

Closed
szymonkups opened this issue Mar 30, 2018 · 4 comments
Closed

Errors in the console when using on JSFiddle #930

szymonkups opened this issue Mar 30, 2018 · 4 comments
Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@szymonkups
Copy link
Contributor

szymonkups commented Mar 30, 2018

Is this a bug report or feature request? (choose one)

🐞 Bug report

πŸ’» Version of CKEditor

1.0.0-beta.1

πŸ“‹ Steps to reproduce

  1. Open https://jsfiddle.net/szymonkups/pr7e2oLb/, make sure console is open.
  2. Press enter inside editor contents.

βœ… Expected result

No errors shown.

❎ Actual result

Error displayed:

Uncaught TypeError: Cannot read property 'parentNode' of null
    at it (scroll.js:265)
    at Je (scroll.js:49)
    at Vm.scrollToTheSelection (view.js:265)
    at yc.listenTo (enter.js:41)
    at yc.fire (emittermixin.js:195)
    at yc.Uf.t.on (enterobserver.js:31)
    at yc.fire (emittermixin.js:195)
    at hm.fire (domeventobserver.js:96)
    at hm.onDomEvent (keyobserver.js:28)
    at Kc.listenTo (domeventobserver.js:81)

πŸ“ƒ Other details that might be useful

JSFiddle is inserting contents inside iframe - this might be connected.

@szymonkups szymonkups added the type:bug This issue reports a buggy (incorrect) behavior. label Mar 30, 2018
@oleq
Copy link
Member

oleq commented Mar 30, 2018

JSFiddle is inserting contents inside iframe - this might be connected.

It's definitely about the iframes.

Edit: I created a local demo of ClassicEditor running inside an iframe. And it works without errors. So there's more to it than I expected.

@Reinmar
Copy link
Member

Reinmar commented May 14, 2018

There's a chance that ckeditor/ckeditor5-utils#240 fixes this issue. It also describes it more precisely.

@Reinmar
Copy link
Member

Reinmar commented May 28, 2018

Encountered it on https://jsfiddle.net/adsvfnn0/.

We should fix this ASAP because it looks very bad and makes it impossible to create valuable JSFiddles.

@Reinmar Reinmar added this to the next milestone May 28, 2018
@oleq oleq changed the title Erros in the console when using on JSFiddle Errors in the console when using on JSFiddle May 29, 2018
@oleq
Copy link
Member

oleq commented May 29, 2018

I found the root of the issue and proposed the fix in ckeditor/ckeditor5-utils#242 based on the initial contributor's PR.

Reinmar added a commit to ckeditor/ckeditor5-utils that referenced this issue Jun 4, 2018
Fix: Error should not be thrown when scrolling the viewport from within an iframe in a different domain. Closes ckeditor/ckeditor5#930.
@Reinmar Reinmar modified the milestones: next, iteration 18 Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants