Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention should not add a white space if a position already followed by one #4651

Closed
oleq opened this issue Apr 8, 2019 · 5 comments · Fixed by #15867
Closed

Mention should not add a white space if a position already followed by one #4651

oleq opened this issue Apr 8, 2019 · 5 comments · Fixed by #15867
Labels
package:mention squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@oleq
Copy link
Member

oleq commented Apr 8, 2019

For instance the following:

foo @ bar

Should result in

foo @completed bar

Instead of

double space now-------v
        foo @completed  bar
@oleq
Copy link
Member Author

oleq commented Jun 26, 2019

This makes even more sense since https://github.com/ckeditor/ckeditor5-mention/issues/44 brings support for typing in brackets and quotes. For instance ATM you have to remove a white space after the mention if you want to type "@foo":

type("):     "
type(@):    "@
select:     "@foo // there's a whitespace at the end
backspace:  "@foo // no whitespace after
type("):    "@foo"

Expected

type("):     "
type(@):    "@
select:     "@foo // no whitespace at the end
type("):    "@foo"

@jodator
Copy link
Contributor

jodator commented Jun 27, 2019

ATM we only analyze the text before the selection but the check for a whitespace after the inserted mention shouldn't be that big deal :)

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-mention Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:mention labels Oct 9, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 7, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
@FilipTokarski
Copy link
Member

Reopening as we got a report on this recently.

@FilipTokarski FilipTokarski reopened this Feb 1, 2024
@FilipTokarski FilipTokarski added support:2 An issue reported by a commercially licensed client. squad:collaboration Issue to be handled by the Collaboration team. squad:core Issue to be handled by the Core team. and removed resolution:expired This issue was closed due to lack of feedback. status:stale squad:collaboration Issue to be handled by the Collaboration team. labels Feb 1, 2024
@pszczesniak pszczesniak self-assigned this Feb 2, 2024
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Feb 2, 2024
@pszczesniak pszczesniak removed their assignment Feb 5, 2024
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Feb 5, 2024
Dumluregn added a commit that referenced this issue Feb 20, 2024
…-spaces

Fix (mention): Inserting a mention should not append an extra white space if there was one already present in the content. A white space should not follow a mention inserted inside a pair of the empty matching brackets. Closes #4651.
@CKEditorBot CKEditorBot added this to the iteration 72 milestone Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:mention squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants