Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and finish the PoC of the new insertImage #15303

Closed
Witoso opened this issue Nov 3, 2023 · 0 comments · Fixed by #15255
Closed

Improve and finish the PoC of the new insertImage #15303

Witoso opened this issue Nov 3, 2023 · 0 comments · Fixed by #15255
Assignees
@niegowski
Labels
squad:core Issue to be handled by the Core team.
Milestone
iteration 69 (v40...

Comments

@Witoso
Copy link
Member

Witoso commented Nov 3, 2023 •
edited
Loading

Production-ready setup of the insertImage component.
Finishing: #15255
@Witoso Witoso added the squad:core Issue to be handled by the Core team. label Nov 3, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Nov 3, 2023
@niegowski niegowski self-assigned this Nov 6, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Nov 6, 2023
@niegowski niegowski mentioned this issue Dec 2, 2023
Merged
niegowski added a commit that referenced this issue Dec 5, 2023
@niegowski
Merge pull request #15255 from ckeditor/ck/15195-toolbar-nesting-split
0647ba6 
Feature (image): Introduced the image insert dropdown as a consistent UI to insert images through different available integrations like image upload, insert an image with the asset manager, and insert an image via URL. Closes #15303. Closes #15149.

Other (image): The `ImageUploadUI` plugin is loaded by default when the `ImageBlock` or `ImageInline` plugins are loaded. See #15149.

Other (list, ui): The `CollapsibleView` moved from the `list` package to the `ui` package. See #15149.

Other (ui): The `SplitButtonView` constructor and `createDropdown()` helper accepts an instance of a `ButtonView` as an action view customization. See #15149.

Other (upload): The `FileDialogButtonView` is now an instance of the `ButtonView`, not just a wrapper on it. See #15149.

Internal (ckbox, ckfinder, image): The `ImageUploadUI`, `CKBoxUI`, `CKFinderUI`, and `ImageInsertViaUrlUI` plugins are registering integrations in the `ImageInsertUI`.

Internal (core): Added icons for `ImageUploadUI` and its integrations. Added translation contexts for common labels for images insert/replace via file manager.

MINOR BREAKING CHANGE (list): The `CollapsibleView` moved from the `list` package to the `ui` package. You can import it like this: `import { CollapsibleView } from '@ckeditor/ckeditor5-ui';`
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 5, 2023
@CKEditorBot CKEditorBot added this to the iteration 69 milestone Dec 5, 2023
@CKEditorBot CKEditorBot mentioned this issue Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
squad:core Issue to be handled by the Core team.
Projects
None yet
Milestone
iteration 69 (v40.2.0)
Development

Successfully merging a pull request may close this issue.

New UI for insert image feature ckeditor/ckeditor5
3 participants
@niegowski @Witoso @CKEditorBot