Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drag & drop] Balloon block button #15029

Closed
Tracked by #13933
Witoso opened this issue Sep 20, 2023 · 1 comment · Fixed by #15071
Closed
Tracked by #13933

[Drag & drop] Balloon block button #15029

Witoso opened this issue Sep 20, 2023 · 1 comment · Fixed by #15071
Labels
package:clipboard squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Witoso
Copy link
Member

Witoso commented Sep 20, 2023

📝 Provide a description of the improvement

  • Implement the support for the RTL in block balloon toolbar drag.
  • During the start of the dragging by icon focus the editable.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@Witoso Witoso added package:clipboard package:core squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature. and removed package:core labels Sep 20, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Sep 20, 2023
@Witoso Witoso changed the title [Drag & drop] RTL support [Drag & drop] Balloon block button Sep 20, 2023
@Witoso Witoso mentioned this issue Sep 21, 2023
16 tasks
@Witoso
Copy link
Member Author

Witoso commented Sep 25, 2023

RTL support: add implementation to check the elements on the left.

const clientX = domEvent.clientX + 100;
const clientY = domEvent.clientY;
const target = document.elementFromPoint( clientX, clientY );

@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 26, 2023
niegowski added a commit that referenced this issue Sep 26, 2023
Internal (clipboard): The balloon block toolbar should be draggable in the RTL editor. Closes #15029.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 26, 2023
@CKEditorBot CKEditorBot added this to the iteration 67 milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:clipboard squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants