Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKeditor5 source code editor breaks with a <template> tag #14933

Closed
sahal-va opened this issue Sep 6, 2023 · 1 comment · Fixed by #15349
Closed

CKeditor5 source code editor breaks with a <template> tag #14933

sahal-va opened this issue Sep 6, 2023 · 1 comment · Fixed by #15349
Assignees
Labels
package:html-support squad:core Issue to be handled by the Core team. support:3 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@sahal-va
Copy link

sahal-va commented Sep 6, 2023

📝 Provide detailed reproduction steps (if any)

When I have a <template> tag in ckeditor5, the editor breaks and 'Source' button doesn't work anymore.
It is reproducible in demo as well https://ckeditor.com/ckeditor-5/demo/html-support/
Enter following code in source editing mode and see if you can toggle source button anymore.
<template id"test"><h1>Hi</h1></template>

  1. Enable source editing mode.
  2. Enter html code with <template> tag.
  3. Disable source editing mode and enable again.
  4. You can see console error throwing.

✔️ Expected result

Source editing should work

❌ Actual result

Source editing breaks

@sahal-va sahal-va added the type:bug This issue reports a buggy (incorrect) behavior. label Sep 6, 2023
@mabryl mabryl added support:3 An issue reported by a commercially licensed client. squad:core Issue to be handled by the Core team. labels Sep 6, 2023
@niegowski niegowski self-assigned this Nov 16, 2023
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Nov 18, 2023
arkflpc added a commit that referenced this issue Nov 20, 2023
Fix (html-support): The editor should not crash when there is a `<template>` element in the content. Closes #14933.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Nov 20, 2023
@CKEditorBot CKEditorBot added this to the iteration 69 milestone Nov 20, 2023
@wimleers
Copy link

wimleers commented Dec 7, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:html-support squad:core Issue to be handled by the Core team. support:3 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants