Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression in the balloon panel tip (arrow) #14652

Closed
oleq opened this issue Jul 25, 2023 · 2 comments Β· Fixed by #14655
Closed

Visual regression in the balloon panel tip (arrow) #14652

oleq opened this issue Jul 25, 2023 · 2 comments Β· Fixed by #14655
Assignees
Labels
intro Good first ticket. package:theme-lark squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@oleq
Copy link
Member

oleq commented Jul 25, 2023

πŸ“ Provide detailed reproduction steps (if any)

Focus an image so that the toolbar shows up.

βœ”οΈ Expected result

image

Balloon tip should be white just like the rest of the panel.

❌ Actual result

image

It's gray.

❓ Possible solution

It's worth checking what caused the regression. It's not the first time.

πŸ“ƒ Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:theme-lark squad:features Issue to be handled by the Features team. type:regression This issue reports a bug that was not present in the previous releases. intro Good first ticket. labels Jul 25, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jul 25, 2023
@Dumluregn Dumluregn self-assigned this Jul 25, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jul 25, 2023
@niegowski
Copy link
Contributor

It was like this since the introduction of accessibility improvements in 35.1.0: https://ckeditor.com/docs/ckeditor5/35.1.0/examples/builds-custom/full-featured-editor.html

@Dumluregn
Copy link
Contributor

As @niegowski mentioned, it started in 35.1.0. But it's the other way around - the panel got brighter, not an arrow got darker.

Until 35.1.0, we had --ck-color-toolbar-background: var(--ck-color-base-foreground); (#fafafa).

Since 35.1.0, it turned into --ck-color-toolbar-background: var(--ck-color-base-background); (#ffffff).

So the arrow should also start using the background color instead of foreground.

oleq added a commit that referenced this issue Jul 25, 2023
Fix (theme-lark): Adjusted the balloon tip color to match the rest of the panel. Closes #14652.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jul 25, 2023
@CKEditorBot CKEditorBot added this to the iteration 65 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro Good first ticket. package:theme-lark squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants