Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drag & drop, intro] Improve the drop target line #14645

Closed
Tracked by #13933
Witoso opened this issue Jul 24, 2023 · 2 comments · Fixed by #14970
Closed
Tracked by #13933

[Drag & drop, intro] Improve the drop target line #14645

Witoso opened this issue Jul 24, 2023 · 2 comments · Fixed by #14970
Assignees
Labels
package:clipboard squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Witoso
Copy link
Member

Witoso commented Jul 24, 2023

We want to improve the drop target line for both horizontal and vertical lines:

  • Symmetrical approach – arrow should also be added in the horizontal line, 
    • RTL, the arrow should be on the other side.
  • For darker background
    • The lines vertical and horizontal by default should be surrounded by the white stroke (0.5-1px).
    • Outline may be tricky to style, intersections, etc., SVG?
    • Possible scope cut.
  • I should be possible to style both line color and the surrounding stroke by the CSS.

Internal Figma file.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@Witoso Witoso added type:improvement This issue reports a possible enhancement of an existing feature. package:clipboard squad:core Issue to be handled by the Core team. labels Jul 24, 2023
@Witoso Witoso mentioned this issue Jul 24, 2023
16 tasks
@Witoso
Copy link
Member Author

Witoso commented Aug 3, 2023

@dagdzi very worthwhile comment from @niegowski, having half-pixels could look messy (antialiasing, and other subpixel rendering magic), and it would be better to use full pixels.

@dagdzi
Copy link

dagdzi commented Aug 3, 2023

@Witoso In that case, I'd stick with the 2 px line. I think it will be more visible and consistent with the rest of the interface elements.

@Witoso Witoso changed the title [Drag & drop] Improve the drop target line [Drag & drop, intro] Improve the drop target line Aug 21, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Aug 22, 2023
@illia-stv illia-stv self-assigned this Aug 24, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 24, 2023
@illia-stv illia-stv removed their assignment Aug 24, 2023
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels Aug 24, 2023
@pszczesniak pszczesniak self-assigned this Sep 7, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 7, 2023
arkflpc added a commit that referenced this issue Sep 11, 2023
…e-the-drop-target-line

Other (theme-lark): Improve the drag and drop target line. Closes #14645.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 11, 2023
@CKEditorBot CKEditorBot added this to the iteration 67 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:clipboard squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants