-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Drag & drop, intro] Blockquote formatting is lost #14640
Comments
What should happen when only part of the blockquote is selected? Is it "all or nothing" or should we automagically split the blockquote? |
I would say that we need to do a bit of predicting of the user intent (and choosing what's the strongest/most popular/maakes more sense). Possible intents of partial select and dragging:
I'm leaning towards, no 1. As an experiment, I added a quote from you to the top, and I wanted to extract "Is it (...)" to pull it above this sentence as a quote. This is a valid case, and nice behavior (if it worked π ). WDYT? @dagdzi |
@Witoso I am also leaning towards solution no 1. Code blocks currently behave this way, and I think it's intuitive. When we repeat this behavior in the case of blockquote, it will also be a consistent solution. |
Due to technical limitations, in the PR #14891 we will only add support for extending the range when ALL child elements are selected. I've created a new issue #14940 to also extend the range when the selection touches the beginning or end of the parent elements. @Witoso I've added this new issue to the list of |
@filipsobol not sure what are the product/user consequences, it's a bit too tech for me to decide π |
Sorry, let me explain this better using the blockquote example from above. With PR #14891, the blockquote style is only maintained if EVERYTHING within it is selected before dragging (Example 1). However, it would be nice to maintain the blockquote style when the selection doesn't include everything, but touches the beginning or end of the blockquote (Examples 2 and 3). This is skipped for now due to technical limitations described in #14940. Once this is fixed, the blockquote style will NOT be copied only if the selection doesn't touch any of the blockquote ends (Example 4). Example 1: βοΈ The blockquote style is copied when all paragraphs are selected. Example 2: βοΈ The blockquote style is copied when the first two paragraphs are selected (currently skipped). Example 3: βοΈ The blockquote style is copied when the last two paragraphs are selected (currently skipped). Example 4: βοΈ The blockquote style is NOT copied when only the middle paragraph is selected. |
Gotcha, so for now let's do the simplest case I agree, then we can move to more specific scenarios. |
π Provide detailed reproduction steps (if any)
In the experimental drag and drop:
Nagranie.z.ekranu.2023-07-11.o.14.49.29.mov
βοΈ Expected result
Formatting is preserved.
β Actual result
Formatting is lost.
If you'd like to see this fixed sooner, add a π reaction to this post.
The text was updated successfully, but these errors were encountered: