Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKBox command should (allow to) set focus in the opened dialog #14312

Closed
mlewand opened this issue Jun 1, 2023 · 0 comments · Fixed by #14718
Closed

CKBox command should (allow to) set focus in the opened dialog #14312

mlewand opened this issue Jun 1, 2023 · 0 comments · Fixed by #14718
Assignees
Labels
intro Good first ticket. package:ckbox squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@mlewand
Copy link
Contributor

mlewand commented Jun 1, 2023

📝 Provide detailed reproduction steps (if any)

  1. Open v38.0.1 sample with CKBox
  2. Evaluate following code in js console: window.setTimeout( () => editor.execute('ckbox'), 5000 ).
  3. make sure to move back your browser focus back the editor
  4. wait till dialog opens
  5. type random words

✔️ Expected result

Your window focus should go to CKBox dialog (your keyboard actions should be handled by CKBox).

❌ Actual result

Your focus is still in editor, thus you're changing the content of the editor.

❓ Possible solution

If you have ideas, you can list them here. Otherwise, you can delete this section.

📃 Other details

This issue is mostly visible if you're opening CKBox with slash commands:

  1. Go to https://ckeditor.com/docs/ckeditor5/38.0.1/examples/builds-custom/full-featured-editor.html
  2. Focus editor and clear its content.
  3. type /uplo (should yield upload command).
  4. Accpet it.

You expect your focus to be moved to CKBox.

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. intro Good first ticket. package:ckbox labels Jun 1, 2023
@mlewand mlewand added the squad:features Issue to be handled by the Features team. label Jul 27, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jul 28, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 2, 2023
@Witoso Witoso added squad:core Issue to be handled by the Core team. and removed squad:features Issue to be handled by the Features team. labels Aug 22, 2023
arkflpc added a commit that referenced this issue Aug 29, 2023
…-set-focus-in-the-opened-dialog

Fix (ckbox): CKBox dialog should be focused after being opened. Closes #14312.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 29, 2023
@CKEditorBot CKEditorBot added this to the iteration 66 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro Good first ticket. package:ckbox squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants