Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List markers should "stick" to list items when a list is indented #14155

Closed
mabryl opened this issue May 15, 2023 · 1 comment · Fixed by #14759
Closed

List markers should "stick" to list items when a list is indented #14155

mabryl opened this issue May 15, 2023 · 1 comment · Fixed by #14759
Assignees
@mmotyczynska
Labels
package:indent package:list squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 66 (v39...

Comments

@mabryl
Copy link
Contributor

mabryl commented May 15, 2023

📝 Provide a description of the improvement

Currently, in Chromium-based browsers and in Firefox, when a list is indented, the list items move but the list markers keep their position:

indent_chromium

In Safari, the markers "stick" to the items:

indent_safari

Could this behavior be normalized across browsers? The default behavior should probably be the one that's present in Safari.

📃 Other details

  • Browser: Chromium, Firefox, Safari
  • OS: cross-OS
  • CKEditor version: N/A
  • Installed CKEditor plugins: List, Document list, Indent block

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@mabryl mabryl added type:improvement This issue reports a possible enhancement of an existing feature. package:list package:indent support:2 An issue reported by a commercially licensed client. squad:core Issue to be handled by the Core team. labels May 15, 2023
@Witoso Witoso mentioned this issue Jul 21, 2023
Closed
4 tasks
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jul 26, 2023
@Witoso
Copy link
Member

Witoso commented Aug 3, 2023 •
edited
Loading

Scope:

For now, we will turn off the block indentation of the DocumentList, it doesn't work in List, and it's actually indenting paragraphs, and not li or whole ul/ol which would be an expected result.

Rel: #12466

@Witoso Witoso mentioned this issue Aug 3, 2023
Closed
@mmotyczynska mmotyczynska self-assigned this Aug 3, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 3, 2023
@mmotyczynska mmotyczynska mentioned this issue Aug 6, 2023
Merged
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 6, 2023
@niegowski niegowski mentioned this issue Aug 8, 2023
Closed
niegowski added a commit that referenced this issue Aug 29, 2023
@niegowski
Merge pull request #14759 from ckeditor/ck/14155-list-markers-should-…
fec3d4b 
…stick-to-list-items-when-indented

Fix (indent): Block elements should not be indented in Document Lists. Closes #14155.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 29, 2023
@CKEditorBot CKEditorBot added this to the iteration 66 milestone Aug 29, 2023
@CKEditorBot CKEditorBot mentioned this issue Aug 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmotyczynska mmotyczynska

Labels
package:indent package:list squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 66 (v39.0.2)
4 participants
@Witoso @CKEditorBot @mabryl @mmotyczynska