New list plugin doesn't convert subsequent lists with a different type properly (aka resetting numbering, splitting lists) #12738

mlewand · 2022-10-26T15:34:41Z

📝 Provide detailed reproduction steps (if any)

For context this is a simplified markup produced by MS Word.

Copy following HTML to your clipboard:

<p style="margin-top: 0px; margin-bottom: 0px; line-height: 1">foo</p>

<p style="margin-top: 0px; margin-bottom: 0px; margin-left: 24px; line-height: 1">&nbsp;</p>
<ol style="list-style-type: decimal">
    <li>

        <p style="margin-top: 0px; margin-bottom: 10.67px; line-height: 1.05">foobar</p>
    </li>
</ol>

<p style="margin-top: 0px; margin-bottom: 10.67px; margin-left: 24px; line-height: 1.05">&nbsp;</p>
<ol style="list-style-type: lower-latin">
    <li>

        <p style="margin-top: 0px; margin-bottom: 10.67px; line-height: 1.05">foobar</p>
    </li>
    <li>

        <p style="margin-top: 0px; margin-bottom: 10.67px; line-height: 1.05">foobar</p>
    </li>
</ol>
<ol start="2" style="list-style-type: decimal">
    <li>

        <p style="margin-top: 0px; margin-bottom: 10.67px; line-height: 1.05">Decimal list item again</p>
    </li>
    <li>

        <p style="margin-top: 0px; margin-bottom: 10.67px; line-height: 1.05">Decimal list item again
        </p>
    </li>
</ol>

<p style="margin-top: 0px; margin-bottom: 10.67px; margin-left: 48px; line-height: 1.05">&nbsp;</p>
<ol style="list-style-type: lower-latin">
    <li>

        <p style="margin-top: 0px; margin-bottom: 10.67px; line-height: 1.05">foobar</p>
    </li>
    <li>

        <p style="margin-top: 0px; margin-bottom: 10.67px; line-height: 1.05">foobar</p>
    </li>
</ol>
<ul style="list-style-type: disc">
    <li>

        <p style="margin-top: 0px; margin-bottom: 10.67px; line-height: 1.05">foobar</p>
    </li>
</ul>
<ol start="3" style="list-style-type: lower-latin">
    <li>

        <p style="margin-top: 0px; margin-bottom: 10.67px; line-height: 1.05">foobar
        </p>
    </li>
</ol>

Open a demo that has new list (a.k.a. document list) implementation in it. Import from Word guide is a good example.
Open js dev console.
Execute editor.setData( `<copiedMarkupHere>` ).

✔️ Expected result

List with two "Decimal list item again" items should be a numbered list.

❌ Actual result

List goes on as alphanum list.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

The text was updated successfully, but these errors were encountered:

Reinmar · 2022-10-26T21:23:55Z

There's a chance we're running here into a limitation of the current implementation – that it does not allow having two subsequent lists of the same type.

@niegowski or @arkflpc, could you confirm that I'm right? Or perhaps this is indeed a bug (as opposed to a missing feature)?

niegowski · 2022-10-27T08:54:51Z

There's a chance we're running here into a limitation of the current implementation – that it does not allow having two subsequent lists of the same type.

You are right. We even implemented a post-fixer to make sure this would not break in RTC:

ckeditor5/packages/ckeditor5-list/src/documentlistproperties/documentlistpropertiesediting.js

Lines 150 to 151 in 13d98de

    
           // Make sure that all items in a single list (items at the same level & listType) have the same properties. 
        
           documentListEditing.on( 'postFixer', ( evt, { listNodes, writer } ) => {

I could imagine a case where one user is modifying a style of the list and some other user is at the same time adding a new list item.

This probably could be someday resolved by adding listId attribute to mark strict boundaries for lists, but currently, it's a missing feature.

jacekbogdanski · 2022-10-27T13:50:31Z

Just theoretically, how feasible would be that fix if IFW would mark lists with an additional attribute? Like a unique ID or something, so it's possible to distinguish different lists? Would that help?

niegowski · 2022-10-27T14:00:30Z

Just theoretically, how feasible would be that fix if IFW would mark lists with an additional attribute? Like a unique ID or something, so it's possible to distinguish different lists? Would that help?

It's not the input problem, it's internally stored in the model (in an input-compatible way) and fixed by the post-fixer.

Reinmar · 2023-04-12T13:51:53Z

Very old DUP of this ticket: #3000.

Witoso · 2023-05-04T12:18:46Z

Scope

Only for DocumentList plugin.
Requires a new docs page / section.

Enablement

New plugin that is added by the user.

Behaviour

Always show two or more separate lists when we have two or more separate lists in the data.
List separator - create an element in the model (not visible, margins will be probably larger) - to explore.
Check the behavior for backspace and forward delete (problems may appear).

Two ul’s next to each other:

<ul>
	<li>LOREM</li>
	<li>IPSUM</li>
</ul>
<ul>
	<li>LOREM</li>
	<li>IPSUM</li>
</ul>

Outcome: This should not be merged.

Two ul’s next to each other, different styles (only list-style-type: or more styles?):

<ul style="list-style-type: square;">
	<li>LOREM</li>
	<li>IPSUM</li>
</ul>
<ul style="list-style-type: disc;">
	<li>LOREM</li>
	<li>IPSUM</li>
</ul>

Outcome: This should not be merged.

ol's

Two ol’s next to each other:

<ol>
	<li>LOREM</li>
	<li>IPSUM</li>
</ol>
<ol>
	<li>LOREM</li>
	<li>IPSUM</li>
</ol>

Outcome: This should not be merged.

Two ol’s next to each other, different styles (only list-style-type: or more styles?).
Probably not relevant as it will be handled by the case above anyway.

<ol>
	<li>LOREM</li>
	<li>IPSUM</li>
</ol>
<ol style="list-style-type:decimal-leading-zero;">
	<li>LOREM</li>
	<li>IPSUM</li>
</ol>

Outcome: This should not be merged.

Real life examples

…rator-plugin Feature (list): Add the `AdjacentListsSupport` plugin to separate lists of the same type. Closes #12738.

mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:list squad:core Issue to be handled by the Core team. labels Oct 26, 2022

martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Dec 12, 2022

Reinmar changed the title ~~New list plugin doesn't convert subsequent lists with a different type properly (a.k.a. document lists)~~ New list plugin doesn't convert subsequent lists with a different type properly (aka resetting numbering, splitting lists) Apr 12, 2023

Reinmar mentioned this issue Apr 12, 2023

Allow splitting lists (creating two subsequent lists) #3000

Closed

This was referenced Apr 14, 2023

Multiple lists are merged together id they are created directly after each other. #13670

Closed

CKEditor 5 is not compiling in Angular 14 #13718

Closed

Witoso mentioned this issue Apr 24, 2023

Support adjacent lists (splitting, resetting numbering) #13945

Closed

1 task

CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Apr 26, 2023

Witoso closed this as completed May 4, 2023

Witoso reopened this May 4, 2023

Witoso mentioned this issue May 5, 2023

Wrong list items indexes #14021

Closed

CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label May 8, 2023

filipsobol self-assigned this May 10, 2023

CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels May 10, 2023

Witoso mentioned this issue May 15, 2023

Nested Bullet lists are pasted incorrectly from word #14098

Closed

filipsobol mentioned this issue May 16, 2023

Add AdjacentListsSupport plugin to separate lists of the same type #14174

Merged

niegowski closed this as completed in #14174 May 23, 2023

niegowski added a commit that referenced this issue May 23, 2023

Merge pull request #14174 from ckeditor/ck/12738-add-documentlistsepa…

574c934

…rator-plugin Feature (list): Add the `AdjacentListsSupport` plugin to separate lists of the same type. Closes #12738.

CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 23, 2023

CKEditorBot added this to the iteration 64 milestone May 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New list plugin doesn't convert subsequent lists with a different type properly (aka resetting numbering, splitting lists) #12738

New list plugin doesn't convert subsequent lists with a different type properly (aka resetting numbering, splitting lists) #12738

mlewand commented Oct 26, 2022 •

edited

Loading

Reinmar commented Oct 26, 2022

niegowski commented Oct 27, 2022

jacekbogdanski commented Oct 27, 2022 •

edited

Loading

niegowski commented Oct 27, 2022

Reinmar commented Apr 12, 2023

Witoso commented May 4, 2023 •

edited

Loading

New list plugin doesn't convert subsequent lists with a different type properly (aka resetting numbering, splitting lists) #12738

New list plugin doesn't convert subsequent lists with a different type properly (aka resetting numbering, splitting lists) #12738

Comments

mlewand commented Oct 26, 2022 • edited Loading

📝 Provide detailed reproduction steps (if any)

✔️ Expected result

❌ Actual result

Reinmar commented Oct 26, 2022

niegowski commented Oct 27, 2022

jacekbogdanski commented Oct 27, 2022 • edited Loading

niegowski commented Oct 27, 2022

Reinmar commented Apr 12, 2023

Witoso commented May 4, 2023 • edited Loading

Scope

Enablement

Behaviour

ol's

Real life examples

mlewand commented Oct 26, 2022 •

edited

Loading

jacekbogdanski commented Oct 27, 2022 •

edited

Loading

Witoso commented May 4, 2023 •

edited

Loading