Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thin space not rendered when content is pasted from Word #12562

Closed
FilipTokarski opened this issue Oct 4, 2022 · 1 comment · Fixed by #14465
Closed

Thin space not rendered when content is pasted from Word #12562

FilipTokarski opened this issue Oct 4, 2022 · 1 comment · Fixed by #14465
Assignees
@arkflpc
Labels
package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 65 (v39...

Comments

@FilipTokarski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

  1. Open sample document
  2. Select the content and copy it
  3. Paste into paste from Word demo

✔️ Expected result

Space is visible.

❌ Actual result

Space is not visible.

❓ Possible solution

After turning off the normalizers in Paste from Word, the space appears.

📃 Other details

  • Browser: Chrome, Firefox - Safari seems fine

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:paste-from-office squad:core Issue to be handled by the Core team. labels Oct 4, 2022
@arkflpc
Copy link
Contributor

arkflpc commented Oct 4, 2022

The payload in Chrome:

<body lang=PL style='tab-interval:35.4pt;word-wrap:break-word'>
<!--StartFragment-->

<p class=MsoNormal><span style='letter-spacing:-.4pt;mso-font-width:90%'>You</span><span
		style='letter-spacing:-1.15pt;mso-font-width:90%'> </span><span
		style='mso-font-width:90%'>are<span style='letter-spacing:-1.05pt'> </span>being<span
		style='letter-spacing:-1.1pt'> </span>asked<span style='letter-spacing:-1.15pt'>
</span><span style='letter-spacing:-.15pt'>to</span><span style='letter-spacing:
-1.1pt'> </span><span style='letter-spacing:-.15pt'>supply</span><span
		style='letter-spacing:-1.2pt'> </span><span style='letter-spacing:-.15pt'>us</span><span
		style='letter-spacing:-1.0pt'> </span>with<span style='letter-spacing:-1.15pt'>
</span><span style='letter-spacing:-.15pt'>and/or</span><span style='letter-spacing:
-.9pt'> </span>verify<span style='letter-spacing:-1.25pt'> </span>information<span
		style='letter-spacing:-1.1pt'> </span><span style='letter-spacing:-.15pt'>that</span><span
		style='letter-spacing:-1.2pt'> </span>will<span style='letter-spacing:-1.0pt'> </span>be<span
		style='letter-spacing:-1.0pt'> </span>used<span style='letter-spacing:-1.15pt'>
</span></span><o:p></o:p></p>

<!--EndFragment-->
</body>

And the one in Safari:

<html xmlns:o="urn:schemas-microsoft-com:office:office"
			xmlns:w="urn:schemas-microsoft-com:office:word"
			xmlns:m="http://schemas.microsoft.com/office/2004/12/omml"
			xmlns="http://www.w3.org/TR/REC-html40"><meta charset="UTF-8"><p class="MsoNormal" style="margin: 0cm; font-size: medium; font-family: Calibri, sans-serif; caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="letter-spacing: -0.4pt;">You</span><span style="letter-spacing: -1.15pt;"><span class="Apple-converted-space"> </span></span><span>are<span style="letter-spacing: -1.05pt;"><span class="Apple-converted-space"> </span></span>being<span style="letter-spacing: -1.1pt;"><span class="Apple-converted-space"> </span></span>asked<span style="letter-spacing: -1.15pt;"><span class="Apple-converted-space"> </span></span><span style="letter-spacing: -0.15pt;">to</span><span style="letter-spacing: -1.1pt;"><span class="Apple-converted-space"> </span></span><span style="letter-spacing: -0.15pt;">supply</span><span style="letter-spacing: -1.2pt;"><span class="Apple-converted-space"> </span></span><span style="letter-spacing: -0.15pt;">us</span><span style="letter-spacing: -1pt;"><span class="Apple-converted-space"> </span></span>with<span style="letter-spacing: -1.15pt;"><span class="Apple-converted-space"> </span></span><span style="letter-spacing: -0.15pt;">and/or</span><span style="letter-spacing: -0.9pt;"><span class="Apple-converted-space"> </span></span>verify<span style="letter-spacing: -1.25pt;"><span class="Apple-converted-space"> </span></span>information<span style="letter-spacing: -1.1pt;"><span class="Apple-converted-space"> </span></span><span style="letter-spacing: -0.15pt;">that</span><span style="letter-spacing: -1.2pt;"><span class="Apple-converted-space"> </span></span>will<span style="letter-spacing: -1pt;"><span class="Apple-converted-space"> </span></span>be<span style="letter-spacing: -1pt;"><span class="Apple-converted-space"> </span></span>used<span style="letter-spacing: -1.15pt;"></span></span><o:p></o:p></p></html>

When the normalizers are commented out in code, the space shows up. The bug must be somewhere within them.

@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Oct 4, 2022
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label May 15, 2023
@arkflpc arkflpc self-assigned this May 29, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels May 29, 2023
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jun 12, 2023
@arkflpc arkflpc mentioned this issue Jun 26, 2023
Merged
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jun 26, 2023
niegowski added a commit that referenced this issue Jun 27, 2023
@niegowski
Merge pull request #14465 from ckeditor/ck/12562-thin-space-not-rendered
0dd197b 
Fix (paste-from-office): Fix of rendering thin space when content is pasted from MSWord. Closes #12562.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 27, 2023
@CKEditorBot CKEditorBot added this to the iteration 65 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 65 (v39.0.0)
Development

Successfully merging a pull request may close this issue.

Thin space not rendered when content is pasted from Word ckeditor/ckeditor5
4 participants
@arkflpc @CKEditorBot @FilipTokarski @martynawierzbicka