Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Style dropdown] Refactor the command #11607

Closed
Tracked by #11574
Reinmar opened this issue Apr 11, 2022 · 1 comment · Fixed by #11703
Closed
Tracked by #11574

[Style dropdown] Refactor the command #11607

Reinmar opened this issue Apr 11, 2022 · 1 comment · Fixed by #11703
Assignees
@niegowski
Labels
package:style squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 53 (v34...

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 11, 2022 •
edited
Loading

Clean up after rapid development of this feature at the end of the last sprint.

Let's also spend ~20% of the time on improving the test suite for it.
@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". squad:core Issue to be handled by the Core team. package:style labels Apr 11, 2022
@Reinmar Reinmar changed the title [Styles dropdown] Refactor the command [Style dropdown] Refactor the command Apr 11, 2022
@niegowski
Copy link
Contributor

I started refactoring it in the https://github.com/ckeditor/ckeditor5/tree/ck/11574-refactor branch.

@niegowski niegowski self-assigned this Apr 27, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Apr 27, 2022
@niegowski niegowski mentioned this issue May 4, 2022
Merged
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels May 4, 2022
oleq added a commit that referenced this issue May 5, 2022
@oleq
Merge pull request #11703 from ckeditor/ck/11574-refactor
5026d51 
Internal (style): The `StyleCommand` got refactored. Closes #11607.

Fix (style): The block style should be applied to all matching selected blocks. Closes #11582.

Fix (style): Inline style can be removed from an inline widget. Closes #11584.

Fix (style): Inline styles should not be enabled inside a code block. Closes #11581

Fix (style): Container styles (for example a block quote style) should be applied properly. Closes #11576.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 5, 2022
@CKEditorBot CKEditorBot added this to the iteration 53 milestone May 5, 2022
@Reinmar Reinmar mentioned this issue Nov 10, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
package:style squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 53 (v34.1.0)
Development

Successfully merging a pull request may close this issue.

Refactored StyleCommand ckeditor/ckeditor5
3 participants
@Reinmar @niegowski @CKEditorBot