Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style dropdown] Inline style can't be removed after adding any paragraph styling (e.g. highlight, bold, italic) #11588

Closed
Tracked by #11574
mateuszzagorski opened this issue Apr 7, 2022 · 1 comment
Assignees
Labels
package:style squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@mateuszzagorski
Copy link
Contributor

mateuszzagorski commented Apr 7, 2022

πŸ“ Provide detailed reproduction steps (if any)

ckeditor5-style_marker.mp4

βœ”οΈ Expected result

Should be possible to remove marker from the selected text

❌ Actual result

Marker can't be removed, unless you remove the highlight/bold/italic etc. first


πŸ“ƒ Other details

  • If you do it the other way around (add highlight/bold/italic etc. to text first, and after that marker on part of the text) - there is no problem as described/shown above.

If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@mateuszzagorski mateuszzagorski added type:bug This issue reports a buggy (incorrect) behavior. package:style squad:core Issue to be handled by the Core team. labels Apr 7, 2022
@dufipl dufipl changed the title [Style dropdown] Inline style can't be removed after adding highlight [Style dropdown] Inline style can't be removed after adding any paragraph styling (e.g. highlight, bold, italic) Apr 7, 2022
@dufipl
Copy link
Contributor

dufipl commented Apr 7, 2022

The issue applies to any paragraph styling. After applying e.g. bold to text you are not able to unselect any of the previously chosen styles from the style dropdown.

@dufipl dufipl added the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Apr 7, 2022
@mlewand mlewand removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Apr 8, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Apr 8, 2022
arkflpc added a commit that referenced this issue Apr 8, 2022
Internal (style): The StyleCommand should be able to detect multiple inline styles applied. Closes #11588. Closes #11586.
@arkflpc arkflpc closed this as completed Apr 8, 2022
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Apr 8, 2022
@CKEditorBot CKEditorBot added this to the upcoming milestone Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:style squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

7 participants