Simplify helper function.

ckeditor · Sep 7, 2023 · 9cf1ed5 · 9cf1ed5
1 parent be765a0
commit 9cf1ed5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/packages/ckeditor5-image/src/image/utils.ts b/packages/ckeditor5-image/src/image/utils.ts
@@ -154,8 +154,7 @@ export function getSizeValueIfInPx( size: string | undefined ): number | null {
  * browser. In this case, the image looks the same as if these styles were applied to attributes instead of styles.
  * That's why we can upcast these styles to width & height attributes instead of resizedWidth and resizedHeight.
  */
-export function widthAndHeightStylesAreBothSet( editor: Editor,	viewElement: ViewElement ): boolean {
-	const imageUtils: ImageUtils = editor.plugins.get( 'ImageUtils' );
+export function widthAndHeightStylesAreBothSet( viewElement: ViewElement ): boolean {
 	const widthStyle = getSizeValueIfInPx( viewElement.getStyle( 'width' ) );
 	const heightStyle = getSizeValueIfInPx( viewElement.getStyle( 'height' ) );
 

diff --git a/packages/ckeditor5-image/src/imageresize/imageresizeediting.ts b/packages/ckeditor5-image/src/imageresize/imageresizeediting.ts
@@ -162,7 +162,7 @@ export default class ImageResizeEditing extends Plugin {
 				model: {
 					key: 'resizedWidth',
 					value: ( viewElement: ViewElement ) => {
-						if ( widthAndHeightStylesAreBothSet( this.editor, viewElement ) ) {
+						if ( widthAndHeightStylesAreBothSet( viewElement ) ) {
 							return null;
 						}
 
@@ -182,7 +182,7 @@ export default class ImageResizeEditing extends Plugin {
 				model: {
 					key: 'resizedHeight',
 					value: ( viewElement: ViewElement ) => {
-						if ( widthAndHeightStylesAreBothSet( this.editor, viewElement ) ) {
+						if ( widthAndHeightStylesAreBothSet( viewElement ) ) {
 							return null;
 						}
 

diff --git a/packages/ckeditor5-image/src/imagesizeattributes.ts b/packages/ckeditor5-image/src/imagesizeattributes.ts
@@ -71,7 +71,7 @@ export default class ImageSizeAttributes extends Plugin {
 				model: {
 					key: 'width',
 					value: ( viewElement: ViewElement ) => {
-						if ( widthAndHeightStylesAreBothSet( this.editor, viewElement ) ) {
+						if ( widthAndHeightStylesAreBothSet( viewElement ) ) {
 							return getSizeValueIfInPx( viewElement.getStyle( 'width' ) );
 						}
 
@@ -96,7 +96,7 @@ export default class ImageSizeAttributes extends Plugin {
 				model: {
 					key: 'height',
 					value: ( viewElement: ViewElement ) => {
-						if ( widthAndHeightStylesAreBothSet( this.editor, viewElement ) ) {
+						if ( widthAndHeightStylesAreBothSet( viewElement ) ) {
 							return getSizeValueIfInPx( viewElement.getStyle( 'height' ) );
 						}