Skip to content

Commit

Permalink
Move 2SCM code to -typing feature.
Browse files Browse the repository at this point in the history
(Step 1 from #7444)
  • Loading branch information
tomalec committed Jun 24, 2020
1 parent 0e23296 commit 7b7c5d0
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion packages/ckeditor5-link/src/linkediting.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import Plugin from '@ckeditor/ckeditor5-core/src/plugin';
import MouseObserver from '@ckeditor/ckeditor5-engine/src/view/observer/mouseobserver';
import bindTwoStepCaretToAttribute from '@ckeditor/ckeditor5-engine/src/utils/bindtwostepcarettoattribute';
import bindTwoStepCaretToAttribute from '@ckeditor/ckeditor5-typing/src/twostepcaretmovement';
import LinkCommand from './linkcommand';
import UnlinkCommand from './unlinkcommand';
import AutomaticDecorators from './utils/automaticdecorators';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

/**
* @module engine/utils/bindtwostepcarettoattribute
* @module typing/twostepcaretmovement
*/

import { keyCodes } from '@ckeditor/ckeditor5-utils/src/keyboard';
Expand Down Expand Up @@ -143,7 +143,7 @@ export default function bindTwoStepCaretToAttribute( { view, model, emitter, att
}

/**
* This is a protected helper–class for {@link module:engine/utils/bindtwostepcarettoattribute}.
* This is a protected helper–class for {@link module:typing/twostepcaretmovement}.
* It handles the state of the 2-step caret movement for a single {@link module:engine/model/model~Model}
* attribute upon the `keypress` in the {@link module:engine/view/view~View}.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph';
import Bold from '@ckeditor/ckeditor5-basic-styles/src/bold';
import Italic from '@ckeditor/ckeditor5-basic-styles/src/italic';

import bindTwoStepCaretToAttribute from '../../../../src/utils/bindtwostepcarettoattribute';
import bindTwoStepCaretToAttribute from '../../src/twostepcaretmovement';

ClassicEditor
.create( document.querySelector( '#editor' ), {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## Two-steps caret movement [#1301](https://github.com/ckeditor/ckeditor5-engine/issues/1301)
## Two-steps caret movement [ckeditor5-engine#1301](https://github.com/ckeditor/ckeditor5-engine/issues/1301)

1. Put the selection at the end of the content.
2. Press the <kbd>←</kbd> key 3 times.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import Underline from '@ckeditor/ckeditor5-basic-styles/src/underline';
import Bold from '@ckeditor/ckeditor5-basic-styles/src/bold';
import Italic from '@ckeditor/ckeditor5-basic-styles/src/italic';

import bindTwoStepCaretToAttribute from '../../src/utils/bindtwostepcarettoattribute';
import bindTwoStepCaretToAttribute from '../../src/twostepcaretmovement';

ClassicEditor
.create( document.querySelector( '#editor-ltr' ), {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## Two-steps caret movement [#1286](https://github.com/ckeditor/ckeditor5-engine/issues/1289)
## Two-steps caret movement [ckeditor5-engine#1286](https://github.com/ckeditor/ckeditor5-engine/issues/1289)

### Moving right
1. Put selection one character before the underline
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@

import VirtualTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/virtualtesteditor';
import DomEmitterMixin from '@ckeditor/ckeditor5-utils/src/dom/emittermixin';
import DomEventData from '../../src/view/observer/domeventdata';
import DomEventData from '@ckeditor/ckeditor5-engine/src/view/observer/domeventdata';
import EventInfo from '@ckeditor/ckeditor5-utils/src/eventinfo';
import bindTwoStepCaretToAttribute, { TwoStepCaretHandler } from '../../src/utils/bindtwostepcarettoattribute';
import Position from '../../src/model/position';
import bindTwoStepCaretToAttribute, { TwoStepCaretHandler } from '../src/twostepcaretmovement';
import Position from '@ckeditor/ckeditor5-engine/src/model/position';
import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
import { keyCodes } from '@ckeditor/ckeditor5-utils/src/keyboard';
import { setData } from '../../src/dev-utils/model';
import { setData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';

describe( 'bindTwoStepCaretToAttribute()', () => {
let editor, model, emitter, selection, view, locale;
Expand Down

0 comments on commit 7b7c5d0

Please sign in to comment.