This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Other: Don't set contenteditable property for widgets on Edge. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 5, 2018
|
@Mgsy This one might not work (although it should) before merging ckeditor/ckeditor5-engine#1450. You could check it now quickly but I'll ping you after ckeditor/ckeditor5-engine#1450 anyway :). |
Reinmar
reviewed
Jul 5, 2018
src/utils.js
Outdated
| // https://github.com/ckeditor/ckeditor5/issues/1079 | ||
| if ( !env.isEdge ) { | ||
| writer.setAttribute( 'contenteditable', 'false', element ); | ||
| } |
Reinmar
reviewed
Jul 5, 2018
src/utils.js
Outdated
| @@ -57,7 +58,11 @@ export function isWidget( element ) { | |||
| * @returns {module:engine/view/element~Element} Returns same element. | |||
| */ | |||
| export function toWidget( element, writer, options = {} ) { | |||
| writer.setAttribute( 'contenteditable', 'false', element ); | |||
| // The selection on Edge behaves better when whole editor contents is in single contentedible element. | |||
There was a problem hiding this comment.
the whole
in a single contenteditable element
Reinmar
reviewed
Jul 5, 2018
src/utils.js
Outdated
| editable.on( 'change:isReadOnly', ( evt, property, is ) => { | ||
| writer.setAttribute( 'contenteditable', is ? 'false' : 'true', editable ); | ||
| } ); | ||
| // Bind contenteditable property to element#isReadOnly. |
There was a problem hiding this comment.
Bind the contenteditable property
Reinmar
reviewed
Jul 5, 2018
src/utils.js
Outdated
| @@ -154,13 +159,17 @@ export function getLabel( element ) { | |||
| export function toWidgetEditable( editable, writer ) { | |||
| writer.addClass( [ 'ck-editor__editable', 'ck-editor__nested-editable' ], editable ); | |||
|
|
|||
| // Set initial contenteditable value. | |||
| writer.setAttribute( 'contenteditable', editable.isReadOnly ? 'false' : 'true', editable ); | |||
| // The selection on Edge behaves better when whole editor contents is in single contentedible element. | |||
There was a problem hiding this comment.
the whole
in a single contenteditable element
|
CC dropped. We need to cover this. You can stub |
|
It works properly. I only noticed that in Edge the cursor changes to
|
Mgsy
approved these changes
Jul 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Don't set contenteditable property for widgets on Edge.
Additional information
env.isEdge: Feature: Add env.isEdge property. ckeditor5-utils#248.