Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing useCKEditorCloud to make it more narrow #311

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Sep 9, 2024

Suggested merge commit message (convention)

Feature: Improve result type of useCKEditorCloud to make CKEditorPremiumFeatures and CKBox non-nullable when proper configuration is passed.
Fix: Rename the languages configuration property to translations in useCKEditorCloud.


Additional information

Must be released before testing:
ckeditor/ckeditor5-integrations-common#25

PRs family:
ckeditor/ckeditor5-react#523

const { CKEditorPremiumFeatures } = await loadCKEditorCloud( {
  version: '43.0.0',
  premium: true,
  ckbox: {
    version: '2.5.1'
  }
} );

Before:

CKEditorPremiumFeatures is nullable type.

After:

CKEditorPremiumFeatures is not nullable type because premium: true is passed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build f15cc5e5-5eaa-449e-9fb0-f8c01d365edd

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build a9ce65d7-d9ba-471c-ae1d-3feea36e2f99: 0.0%
Covered Lines: 79
Relevant Lines: 79

💛 - Coveralls

@Mati365 Mati365 merged commit 9432709 into master Sep 13, 2024
5 checks passed
@Mati365 Mati365 deleted the ck/narrow-cdn-config branch September 13, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants