Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/ckeditor5/1341: Prevent memory leaks #270

Merged
merged 3 commits into from
Jan 22, 2019
Merged

T/ckeditor5/1341: Prevent memory leaks #270

merged 3 commits into from
Jan 22, 2019

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Jan 15, 2019

Suggested merge commit message (convention)

Other: Prevent memory leaks.

Additional information

@jodator jodator mentioned this pull request Jan 15, 2019
Merged
@coveralls
Copy link

coveralls commented Jan 15, 2019 •
edited
Loading

Coverage Status

Coverage increased (+40.6%) to 100.0% when pulling 25529a0 on t/ckeditor5/1341 into e941872 on master.

@oskarwrobel
Copy link
Contributor

Closes https://github.com/ckeditor/ckeditor5-utils/issues/182.

@oskarwrobel
Copy link
Contributor

You can add focusTracker.destroy() in afterAll statement to reach 100% CC for single class tests.

@jodator
Copy link
Contributor Author

jodator commented Jan 16, 2019

@oskarwrobel Thanks the PR is still under construction though ;)

@oleq oleq merged commit 94bc59e into master Jan 22, 2019
@oleq oleq deleted the t/ckeditor5/1341 branch January 22, 2019 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jodator @coveralls @oskarwrobel @oleq