This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Removed translation-utils's add() #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
commented
Mar 27, 2018
|
|
||
| Object.assign( dictionaries[ lang ], translations ); | ||
| // Initialize CKEDITOR_TRANSLATIONS if it's not initialized. | ||
| if ( !window.CKEDITOR_TRANSLATIONS ) { |
There was a problem hiding this comment.
Again, I think that such an access to the global variable is unsafe in envs like Electron, but let's go with it for now. I'll only change it so it imports the global object from src/global.js.
There was a problem hiding this comment.
Or maybe I won't... because it's src/dom/global.js. I'll report a followup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Removed
translation-service~add()function in favor of using safer, always available, manual approach to extendingCKEDITOR_TRANSLATIONSglobal. See ckeditor/ckeditor5#914.BREAKING CHANGES: The
translation-service~add()function was removed. Seetranslation-utilsmodule docs to learn how to add translations.