This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/undo 2 #14
Merged
T/undo 2 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and improved selection restoring algorithm.
7388779 to
c9e8248
Compare
|
|
||
| // Performs a transformation of delta set `setToTransform` by given delta set `setToTransformBy`. | ||
| // If `setToTransform` deltas are more important than `setToTransformBy` deltas, `isStrong` should be true. | ||
| export function transformDelta( setToTransform, setToTransformBy, isStrong = false ) { |
There was a problem hiding this comment.
I think we can imagine some clearing mechanisms in model that will like to clear undo stack. We were discussing things like setData recently. If needed, this method can be expanded to clear only first X items, etc.
| * reversed delta that was later transformed. | ||
| * | ||
| * But what about that selection? For batch `C`, undo feature remembers selection just before `C1` was applied. It can be | ||
| * visualized between delta `B2` and `B3` (see fig. 3). Obviously a lot happened to the document since the selection |
There was a problem hiding this comment.
"a lot"? Isn't it only "B3" since we reversed "C"?
There was a problem hiding this comment.
Maybe "a lot" is overstating here, yes. But what I've meant is that we actually applied five deltas. But it's true that for that selection only B3 happens. I'll change it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a rewrite of Undo feature, based on experience gained before/during/after hackathon when I had a chance to play a lot with undo and come up with multiple weird scenarios. It fixes ckeditor/ckeditor5#2684 ckeditor/ckeditor5#2689 ckeditor/ckeditor5#2685 ckeditor/ckeditor5#2690. Funny enough, ckeditor/ckeditor5#2690 wasn't only optimization thing but, when applied to operational transformations done by undo, also enabled creating undo algorithm that finally outputs correct results.
Other than that the PR introduces:
RedoCommandas the redo algorithms divereged heavily from undo (it was one command before)BaseCommandwhich is a base forUndoCommandandRedoCommandNeeds ckeditor/ckeditor5-engine#499