Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Merge branch 'master' into t/ckeditor5/1404
Browse files Browse the repository at this point in the history
  • Loading branch information
oleq committed Aug 13, 2019
2 parents 8e94939 + 8cc3436 commit e671572
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/commands/mergecellcommand.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export default class MergeCellCommand extends Command {
/**
* Returns a cell that can be merged with the current cell depending on the command's direction.
*
* @returns {module:engine/model/element|undefined}
* @returns {module:engine/model/element~Element|undefined}
* @private
*/
_getMergeableCell() {
Expand Down
2 changes: 1 addition & 1 deletion src/ui/inserttableview.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default class InsertTableView extends View {
* @member {String} #label
*/
this.bind( 'label' )
.to( this, 'columns', this, 'rows', ( columns, rows ) => `${ rows } x ${ columns }` );
.to( this, 'columns', this, 'rows', ( columns, rows ) => `${ rows } × ${ columns }` );

this.setTemplate( {
tag: 'div',
Expand Down
6 changes: 3 additions & 3 deletions tests/ui/inserttableview.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe( 'InsertTableView', () => {
} );

it( 'sets #label to default rows & columns', () => {
expect( view.label ).to.equal( '0 x 0' );
expect( view.label ).to.equal( '0 × 0' );
} );

it( 'creates #element from template', () => {
Expand Down Expand Up @@ -85,11 +85,11 @@ describe( 'InsertTableView', () => {
it( 'binds #label to rows & columns', () => {
view.rows = 3;

expect( view.label ).to.equal( '3 x 0' );
expect( view.label ).to.equal( '3 × 0' );

view.columns = 7;

expect( view.label ).to.equal( '3 x 7' );
expect( view.label ).to.equal( '3 × 7' );
} );

it( 'mousedown event should be prevented', () => {
Expand Down

0 comments on commit e671572

Please sign in to comment.