Update ckeditor.js #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of #7 I copied all the code from `ckeditor.js` in my project (in a new component file). I'm using `create-react-app` and eslint. So the errors: - [eslint] componentWillReceiveProps is deprecated since React 16.3.0, use UNSAFE_componentWillReceiveProps instead, see https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops (react/no-deprecated) - [eslint] shouldComponentUpdate should be placed after UNSAFE_componentWillReceiveProps (react/sort-comp) - [eslint] shouldComponentUpdate should be placed after componentDidMount (react/sort-comp) - [eslint] render should be placed after _destroyEditor (react/sort-comp) - [eslint] Default prop types declarations should be sorted alphabetically (react/jsx-sort-default-props) - [eslint] Must use destructuring props assignment (react/destructuring-assignment) **What is still a problem** (and I don't know how to fix): - [eslint] UNSAFE_componentWillReceiveProps is unsafe for use in async rendering, see https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html (react/no-unsafe) - Unexpected console statement. (no-console) (62, 9) - JSX props should not use arrow functions (react/jsx-no-bind) (68, 17) - Prop type `object` is forbidden (react/forbid-prop-types) (74, 3) - propType "onChange" is not required, but has no corresponding defaultProp declaration. (react/require-default-props) (77, 3) - propType "onInit" is not required, but has no corresponding defaultProp declaration. (react/require-default-props) (78, 3)
|
I'm closing this PR because of proposed changes don't match to our guide. We will introduce a linter and then we will be able to fix errors (if any). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #7 I copied all the code from
ckeditor.jsin my project (in a new component file).I'm using
create-react-appand eslint. So the errors:[eslint] componentWillReceiveProps is deprecated since React 16.3.0, use UNSAFE_componentWillReceiveProps instead, see https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops (react/no-deprecated)
[eslint] shouldComponentUpdate should be placed after UNSAFE_componentWillReceiveProps (react/sort-comp)
[eslint] shouldComponentUpdate should be placed after componentDidMount (react/sort-comp)
[eslint] render should be placed after _destroyEditor (react/sort-comp)
[eslint] Default prop types declarations should be sorted alphabetically (react/jsx-sort-default-props)
[eslint] Must use destructuring props assignment (react/destructuring-assignment)
What is still a problem (and I don't know how to fix):
[eslint] UNSAFE_componentWillReceiveProps is unsafe for use in async rendering, see https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html (react/no-unsafe)
Unexpected console statement. (no-console) (62, 9)
JSX props should not use arrow functions (react/jsx-no-bind) (68, 17)
Prop type
objectis forbidden (react/forbid-prop-types) (74, 3)propType "onChange" is not required, but has no corresponding defaultProp declaration. (react/require-default-props) (77, 3)
propType "onInit" is not required, but has no corresponding defaultProp declaration. (react/require-default-props) (78, 3)