Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name to @ckeditor/ckeditor5-react and publish first dev preview #5

Closed
6 tasks done
Reinmar opened this issue Jun 5, 2018 · 15 comments
Closed
6 tasks done
Assignees
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 5, 2018

People started landing here and reporting that this pkg is missing (#2, #4), so let's publish something.

TODO:

@Reinmar
Copy link
Member Author

Reinmar commented Jun 5, 2018

Doh... without the following PRs: ckeditor/ckeditor5-editor-classic#73, ckeditor/ckeditor5-editor-inline#38, ckeditor/ckeditor5-editor-balloon#19 releasing @ckeditor/ckeditor5-react does not make sense ;/

So, it's going to take us more than a week before we have to wait for the editors to be out (planned ~19.06).

@pomek
Copy link
Member

pomek commented Jun 6, 2018

I pushed a branch (#t/5) which contains some fixes for this repository (cleaned up package.json, added license file, etc.).

It requires to attach our changelog generator and finally review the README and package.json.

Because we won't release the package now, I will back to the issue in the future.

@pomek
Copy link
Member

pomek commented Jun 6, 2018

TODO: Validate (and fix) the regexp on Windows environments.

@ma2ciek
Copy link
Contributor

ma2ciek commented Jun 6, 2018

I'd suggest minifying the build and add a proper header to that file like we have in other builds.

@Reinmar Reinmar modified the milestones: iteration 18, iteration 19 Jun 8, 2018
@RaulEscobarRivas
Copy link

RaulEscobarRivas commented Jun 11, 2018

may I suggest changing the folder structure ? as you actually have to get the resource from the src file:
import CKEditor5 from 'cke5-react/src/ckeditor';

maybe add an index.js in the package root folder ? or just get rid of the src folder and have the source file at the same level of the root ?

@pomek
Copy link
Member

pomek commented Jun 11, 2018

We will compile and minify the source file. The same we do with the builds. We want to also set up the build file as the main package file in package.json so:

import CKEditor5 from '@ckeditor/ckeditor5-react';

will be enough.

@Reinmar Reinmar modified the milestones: iteration 19, next Jun 26, 2018
@cola9k
Copy link

cola9k commented Jun 28, 2018

Dear @Reinmar
I tried to install @ckeditor/ckeditor5-react, but it did not work.
Will react no longer work with the Cke5 version?

@Reinmar
Copy link
Member Author

Reinmar commented Jun 28, 2018

As mentioned in the readme:

NOTE: This package is not yet published on npm. It's a developer's preview available only through GitHub.

See #5 for more information.

@Reinmar
Copy link
Member Author

Reinmar commented Jun 28, 2018

Some status update – we wanted to release this pkg ASAP, but it's blocked by breaking changes in ckeditor5-core. We couldn't release these changes last week due to their breaking nature, so the whole thing got delayed by ~3 weeks.

@tgroshon
Copy link

tgroshon commented Jul 3, 2018

Looks like all the needed editor PRs except ckeditor/ckeditor5-editor-balloon#19 have been merged!

How we doing now?

@Reinmar
Copy link
Member Author

Reinmar commented Jul 3, 2018

I'm on it. The release window is next week. That will unblock the React integration.

@robrechtme
Copy link

What's the ETA for a stable npm package?

@Reinmar
Copy link
Member Author

Reinmar commented Jul 13, 2018

We have a delay with the release of CKEditor 5. It was meant to be this week but we didn't manage to make it and it will be out next week.

Then, we still need minimum a week to release the ckeditor5-react package. That's the minimum it may take.

ma2ciek added a commit that referenced this issue Jul 24, 2018
Other: First developer preview version. It contains ready-to-use `CKEditor` component that allows using CKEditor 5 Builds and CKEditor 5 Framework in React application. Closes #1. Closes #3. Closes #5. Closes #7. Closes #13. Closes #15.
@pomek
Copy link
Member

pomek commented Jul 24, 2018

The package should be published tomorrow or on Thursday.

@Reinmar Reinmar modified the milestones: next, iteration 20 Jul 24, 2018
@pomek
Copy link
Member

pomek commented Jul 26, 2018

The first version has just been published.

Now using npm install @ckeditor/ckeditor5-react will install the package in version 1.0.0-beta.1.

The feedback is welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

7 participants