-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the name to @ckeditor/ckeditor5-react and publish first dev preview #5
Comments
Doh... without the following PRs: ckeditor/ckeditor5-editor-classic#73, ckeditor/ckeditor5-editor-inline#38, ckeditor/ckeditor5-editor-balloon#19 releasing So, it's going to take us more than a week before we have to wait for the editors to be out (planned ~19.06). |
I pushed a branch (#t/5) which contains some fixes for this repository (cleaned up package.json, added license file, etc.). It requires to attach our changelog generator and finally review the README and package.json. Because we won't release the package now, I will back to the issue in the future. |
TODO: Validate (and fix) the regexp on Windows environments. |
I'd suggest minifying the build and add a proper header to that file like we have in other builds. |
may I suggest changing the folder structure ? as you actually have to get the resource from the src file: maybe add an index.js in the package root folder ? or just get rid of the src folder and have the source file at the same level of the root ? |
We will compile and minify the source file. The same we do with the builds. We want to also set up the build file as the main package file in import CKEditor5 from '@ckeditor/ckeditor5-react'; will be enough. |
Dear @Reinmar |
As mentioned in the readme:
|
Some status update – we wanted to release this pkg ASAP, but it's blocked by breaking changes in |
Looks like all the needed editor PRs except ckeditor/ckeditor5-editor-balloon#19 have been merged! How we doing now? |
I'm on it. The release window is next week. That will unblock the React integration. |
What's the ETA for a stable npm package? |
We have a delay with the release of CKEditor 5. It was meant to be this week but we didn't manage to make it and it will be out next week. Then, we still need minimum a week to release the ckeditor5-react package. That's the minimum it may take. |
The package should be published tomorrow or on Thursday. |
The first version has just been published. Now using The feedback is welcomed. |
People started landing here and reporting that this pkg is missing (#2, #4), so let's publish something.
TODO:
@ckeditor/ckeditor5-react
and update the docs.The text was updated successfully, but these errors were encountered: