This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Soft break inside list element will be handled correctly. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
suggested changes
Nov 13, 2018
|
Done. This PR requires ckeditor/ckeditor5-engine#1591 now.
|
Reinmar
added a commit
to ckeditor/ckeditor5-engine
that referenced
this pull request
Nov 13, 2018
Other: `ContainerElement#getFillerOffset` can be now re-used in other places in the code (it was exported from the module). See ckeditor/ckeditor5-list#117.
Reinmar
reviewed
Nov 13, 2018
Co-Authored-By: pomek <pomek@users.noreply.github.com>
pomek
commented
Nov 13, 2018
Reinmar
approved these changes
Nov 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Block filler will be inserted into the list item if its last child is a
<br>element. Closes ckeditor/ckeditor5#1312.