Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/ckeditor5/810: Made the link form buttons thicker with a fill color and no background. #184

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

oleq
Copy link
Member

@oleq oleq commented Mar 15, 2018

@oleq oleq requested a review from dkonopka March 15, 2018 11:23
@oleq
Copy link
Member Author

oleq commented Mar 15, 2018

Retina

screen shot 2018-03-15 at 12 14 02

Non-retina

screen shot 2018-03-15 at 12 15 18

@scofalik
Copy link
Contributor

scofalik commented Mar 15, 2018

Just a small thing but could we put those icons a bit closer to each other? So the gap between them is same as gaps between field and icon, or icon and tooltip border. If it is just padding (no margins) then I guess we can't. IDK. Just my 5 cents, it was bothering me :P

@oleq
Copy link
Member Author

oleq commented Mar 15, 2018

@scofalik We cannot because it's a framework not a patchwork :P

image

@scofalik
Copy link
Contributor

Yeah that's what I thought. Bummer.

@oleq
Copy link
Member Author

oleq commented Mar 15, 2018

I found out I slightly exaggerated the thickness. I updated the icons:

Retina
screen shot 2018-03-15 at 12 31 55

Non-retina
screen shot 2018-03-15 at 12 34 19

@dkonopka dkonopka merged commit 45292f1 into master Mar 15, 2018
@dkonopka dkonopka deleted the t/ckeditor5/810 branch March 15, 2018 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants